[PATCH] build: Fix dependencies for start and asm files

[Chris Johns]

On 17/9/20 4:26 pm, Sebastian Huber wrote:
> On 17/09/2020 08:21, Chris Johns wrote:
>> On 17/9/20 4:11 pm, Sebastian Huber wrote:
>>> On 17/09/2020 08:07, Chris Johns wrote:
>>>> On 17/9/20 3:57 pm, Sebastian Huber wrote:
>>>>> + at feature("explicit_asm_target")
>>>> explicit_asm?
>>> asm_explicit_target? The target is the important thing here.
>> Hmmm ... oh .. it is a dependency of a test to rebuild a test. Is this because
>> the test is not directly dependent on the start object file self?
> 
> Unfortunately the fix for #3846 and #4080 needs to be combined, because the fix
> for #3846 requires the removal of "before=["cstlib"]". This patch fixes two issues.
> 
> 1. The tracking of start file dependencies.
> 
> 2. Reflect that executables depend on the start files.
> 
> We need a start.o file in the right path, and not for example a start.S.17.o
> file in some path. This part is addressed by the "explicit_asm_target" feature.
> 
> This:
> 
> @after("apply_link")
> @feature("cprogram", "cxxprogram")
> def process_start_files(self):
>     if getattr(self, "start_files", False):
>         self.link_task.dep_nodes.extend(self.bld.start_files)
> 
> addresses 2.
> 

Thank you for the explanation. OK to push.

chris