[rtems commit] build: Fix enabled-by evaluation

Chris Johns chrisj at rtems.org
Sun Sep 27 22:02:25 UTC 2020


On 27/9/20 5:40 pm, Sebastian Huber wrote:
> Module:    rtems
> Branch:    master
> Commit:    b8d84015a4bc30f280b3e39f3f806e1ec0b2ec7a
> Changeset: http://git.rtems.org/rtems/commit/?id=b8d84015a4bc30f280b3e39f3f806e1ec0b2ec7a
> 
> Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
> Date:      Sun Sep 27 09:35:06 2020 +0200
> 
> build: Fix enabled-by evaluation
> 
> For the enabled-by evaluation we have to use the BSP name defined by the
> build specification and not the user.
> 
> Update #3818.
> 
> ---
> 
>  wscript | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/wscript b/wscript
> index 5a6400e..e5ac53f 100755
> --- a/wscript
> +++ b/wscript
> @@ -1355,12 +1355,13 @@ def configure_variant(conf, cp, bsp_map, path_list, top_group, variant):

I think the below fragment needs a comment along the lines of the commit
message. It is difficult to see this and understand what is happening.

>      conf.setenv(variant)
>      arch, bsp_name = variant.split("/")
>      bsp_base = bsp_map.get(bsp_name, bsp_name)
> +    arch_bsp = arch + "/" + bsp_base

Thanks
Chris


More information about the devel mailing list