[PATCH] Fixes for TMS570 BSP

[Gedare Bloom]

Hi Robin, Pavel:

On Mon, Apr 19, 2021 at 2:57 AM Robin Müller <robin.mueller.m at gmail.com> wrote:
>
> If this was intentional, I can also adapt the lwIP port sources to use ti/herc. I was not sure about that.
>
I think Pavel should comment. I believe at the time care was taken to
avoid importing TI HalCoGen code generation, and maybe this missing
ti_herc is an artifact from that. I think over time TI has moved
toward providing a slightly better license (2-clause BSD with hardware
restriction) on their HAL/SOC libs. We won't merge code with the
hardware restriction clause. So it can be a little problematic to get
things working nicely, it has to be well documented the steps to
reproduce setups based on restrictive vendor-provided code.

That's what I remember anyway. Pavel may explain better.
Gedare

> Kind Regards
> Robin
>
> On Mon, 19 Apr 2021 at 10:55, Robin Mueller <robin.mueller.m at gmail.com> wrote:
>>
>> When compiling the lwIP port for the TMS570, there
>> were issues with the BSP. Headers are expected in a folder
>> named ti_herc which did not exist. This fixes the issue.
>>
>> Furthermore, there were multiple warnings about define redefinitions.
>> This was fixed as well.
>> ---
>>  bsps/arm/tms570/include/bsp/irq.h  | 6 +++---
>>  spec/build/bsps/arm/tms570/obj.yml | 2 +-
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/bsps/arm/tms570/include/bsp/irq.h b/bsps/arm/tms570/include/bsp/irq.h
>> index c37ebadbc4..0b6ea1e6fd 100644
>> --- a/bsps/arm/tms570/include/bsp/irq.h
>> +++ b/bsps/arm/tms570/include/bsp/irq.h
>> @@ -34,7 +34,7 @@
>>
>>  #define BSP_INTERRUPT_VECTOR_MIN 0U
>>  #define TMS570_IRQ_ESM_HIGH 0
>> -#define TMS570_IRQ_RESERVED 1
>> +#define TMS570_IRQ_RESERVED_0 1
>>  #define TMS570_IRQ_TIMER_0 2
>>  #define TMS570_IRQ_TIMER_1 3
>>  #define TMS570_IRQ_TIMER_2 4
>> @@ -50,7 +50,7 @@
>>  #define TMS570_IRQ_ADC1_EVENT 14
>>  #define TMS570_IRQ_ADC1_GROUP_1 15
>>  #define TMS570_IRQ_CAN1_HIGH 16
>> -#define TMS570_IRQ_RESERVED 17
>> +#define TMS570_IRQ_RESERVED_1 17
>>  #define TMS570_IRQ_FLEXRAY_HIGH 18
>>  #define TMS570_IRQ_CRC_1 19
>>  #define TMS570_IRQ_ESM_LOW 20
>> @@ -63,7 +63,7 @@
>>  #define TMS570_IRQ_SCI_LEVEL_1 27
>>  #define TMS570_IRQ_ADC1_GROUP_2 28
>>  #define TMS570_IRQ_CAN1_LOW 29
>> -#define TMS570_IRQ_RESERVED
>> +#define TMS570_IRQ_RESERVED_2 30
>>  #define TMS570_IRQ_ADC1_MAG 31
>>  #define TMS570_IRQ_FLEXRAY_LOW 32
>>  #define TMS570_IRQ_DMA_FTCA 33
>> diff --git a/spec/build/bsps/arm/tms570/obj.yml b/spec/build/bsps/arm/tms570/obj.yml
>> index 7932299c1d..36f99a700e 100644
>> --- a/spec/build/bsps/arm/tms570/obj.yml
>> +++ b/spec/build/bsps/arm/tms570/obj.yml
>> @@ -29,7 +29,7 @@ install:
>>    - bsps/arm/tms570/include/bsp/tms570_selftest_parity.h
>>    - bsps/arm/tms570/include/bsp/tms570lc4357-pins.h
>>    - bsps/arm/tms570/include/bsp/tms570ls3137zwt-pins.h
>> -- destination: ${BSP_INCLUDEDIR}/bsp/ti/herc
>> +- destination: ${BSP_INCLUDEDIR}/bsp/ti_herc
>>    source:
>>    - bsps/arm/tms570/include/bsp/ti_herc/reg_adc.h
>>    - bsps/arm/tms570/include/bsp/ti_herc/reg_ccmsr.h
>> --
>> 2.29.2.windows.2
>>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel