[PATCH rtems 2/2] testsuites: Remove telnetd01
Vijay Kumar Banerjee
vijay at rtems.org
Thu Apr 22 18:17:25 UTC 2021
On Thu, Apr 22, 2021 at 12:16 PM Gedare Bloom <gedare at rtems.org> wrote:
>
> Should the commit message indicate where these files have been moved?
>
Ok, I'll send a v2 with a clearer message and add it in the messages
that it's being removed as it cannot be tested without a networking
stack.
> Otherwise, it's ok to me. Can't run this test without building a stack.
>
> On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee <vijay at rtems.org> wrote:
> >
> > ---
> > spec/build/testsuites/libtests/grp.yml | 2 -
> > spec/build/testsuites/libtests/telnetd01.yml | 22 ----
> > testsuites/libtests/telnetd01/init.c | 120 -------------------
> > testsuites/libtests/telnetd01/telnetd01.doc | 24 ----
> > testsuites/libtests/telnetd01/telnetd01.scn | 11 --
> > 5 files changed, 179 deletions(-)
> > delete mode 100644 spec/build/testsuites/libtests/telnetd01.yml
> > delete mode 100644 testsuites/libtests/telnetd01/init.c
> > delete mode 100644 testsuites/libtests/telnetd01/telnetd01.doc
> > delete mode 100644 testsuites/libtests/telnetd01/telnetd01.scn
> >
> > diff --git a/spec/build/testsuites/libtests/grp.yml b/spec/build/testsuites/libtests/grp.yml
> > index 5695fc7f06..20a593a5d3 100644
> > --- a/spec/build/testsuites/libtests/grp.yml
> > +++ b/spec/build/testsuites/libtests/grp.yml
> > @@ -258,8 +258,6 @@ links:
> > uid: tar02
> > - role: build-dependency
> > uid: tar03
> > -- role: build-dependency
> > - uid: telnetd01
> > - role: build-dependency
> > uid: termios
> > - role: build-dependency
> > diff --git a/spec/build/testsuites/libtests/telnetd01.yml b/spec/build/testsuites/libtests/telnetd01.yml
> > deleted file mode 100644
> > index 9f5bda84d9..0000000000
> > --- a/spec/build/testsuites/libtests/telnetd01.yml
> > +++ /dev/null
> > @@ -1,22 +0,0 @@
> > -SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> > -build-type: test-program
> > -cflags: []
> > -copyrights:
> > -- Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
> > -cppflags: []
> > -cxxflags: []
> > -enabled-by:
> > -- RTEMS_NETWORKING
> > -features: c cprogram
> > -includes:
> > -- cpukit/libnetworking
> > -ldflags: []
> > -links: []
> > -source:
> > -- testsuites/libtests/telnetd01/init.c
> > -stlib: []
> > -target: testsuites/libtests/telnetd01.exe
> > -type: build
> > -use-after:
> > -- telnetd
> > -use-before: []
> > diff --git a/testsuites/libtests/telnetd01/init.c b/testsuites/libtests/telnetd01/init.c
> > deleted file mode 100644
> > index a17126bf41..0000000000
> > --- a/testsuites/libtests/telnetd01/init.c
> > +++ /dev/null
> > @@ -1,120 +0,0 @@
> > -/*
> > - * Copyright (c) 2018 embedded brains GmbH. All rights reserved.
> > - *
> > - * embedded brains GmbH
> > - * Dornierstr. 4
> > - * 82178 Puchheim
> > - * Germany
> > - * <rtems at embedded-brains.de>
> > - *
> > - * The license and distribution terms for this file may be
> > - * found in the file LICENSE in this distribution or at
> > - * http://www.rtems.org/license/LICENSE.
> > - */
> > -
> > -#ifdef HAVE_CONFIG_H
> > -#include "config.h"
> > -#endif
> > -
> > -#include <sys/stat.h>
> > -#include <fcntl.h>
> > -#include <string.h>
> > -
> > -#include <rtems.h>
> > -#include <rtems/rtems_bsdnet.h>
> > -#include <rtems/telnetd.h>
> > -
> > -#include <tmacros.h>
> > -
> > -const char rtems_test_name[] = "TELNETD 1";
> > -
> > -struct rtems_bsdnet_config rtems_bsdnet_config;
> > -
> > -static void command(char *device_name, void *arg)
> > -{
> > -}
> > -
> > -static void test_command_null(void)
> > -{
> > - static const rtems_telnetd_config_table config = {
> > - .command = NULL
> > - };
> > - rtems_status_code sc;
> > -
> > - sc = rtems_telnetd_start(&config);
> > - rtems_test_assert(sc == RTEMS_INVALID_ADDRESS);
> > -}
> > -
> > -static void test_cannot_start_server_task(void)
> > -{
> > - static const rtems_telnetd_config_table config = {
> > - .command = command,
> > - .priority = UINT32_MAX
> > - };
> > - rtems_status_code sc;
> > -
> > - sc = rtems_telnetd_start(&config);
> > - rtems_test_assert(sc == RTEMS_UNSATISFIED);
> > -}
> > -
> > -static void test_successful_start(void)
> > -{
> > - static const rtems_telnetd_config_table config = {
> > - .command = command,
> > - .stack_size = RTEMS_MINIMUM_STACK_SIZE
> > - };
> > - rtems_status_code sc;
> > -
> > - sc = rtems_telnetd_start(&config);
> > - rtems_test_assert(sc == RTEMS_SUCCESSFUL);
> > -}
> > -
> > -static void test_already_started(void)
> > -{
> > - static const rtems_telnetd_config_table config = {
> > - .command = command
> > - };
> > - rtems_status_code sc;
> > -
> > - sc = rtems_telnetd_start(&config);
> > - rtems_test_assert(sc == RTEMS_RESOURCE_IN_USE);
> > -}
> > -
> > -static rtems_task Init(rtems_task_argument argument)
> > -{
> > - int rv;
> > -
> > - TEST_BEGIN();
> > -
> > - rv = rtems_bsdnet_initialize_network();
> > - rtems_test_assert(rv == 0);
> > -
> > - test_command_null();
> > - test_cannot_start_server_task();
> > - test_successful_start();
> > - test_already_started();
> > -
> > - TEST_END();
> > - rtems_test_exit(0);
> > -}
> > -
> > -#define CONFIGURE_INIT
> > -
> > -#define CONFIGURE_MICROSECONDS_PER_TICK 10000
> > -
> > -#define CONFIGURE_APPLICATION_NEEDS_CLOCK_DRIVER
> > -#define CONFIGURE_APPLICATION_NEEDS_SIMPLE_CONSOLE_DRIVER
> > -
> > -#define CONFIGURE_MAXIMUM_FILE_DESCRIPTORS (3 + 1 + 5 * 4)
> > -
> > -#define CONFIGURE_MAXIMUM_TASKS 8
> > -
> > -#define CONFIGURE_MAXIMUM_POSIX_KEYS 1
> > -
> > -#define CONFIGURE_INITIAL_EXTENSIONS RTEMS_TEST_INITIAL_EXTENSION
> > -
> > -#define CONFIGURE_RTEMS_INIT_TASKS_TABLE
> > -
> > -#define CONFIGURE_INIT_TASK_ATTRIBUTES RTEMS_FLOATING_POINT
> > -
> > -#include <rtems/confdefs.h>
> > diff --git a/testsuites/libtests/telnetd01/telnetd01.doc b/testsuites/libtests/telnetd01/telnetd01.doc
> > deleted file mode 100644
> > index fe1a4d31a3..0000000000
> > --- a/testsuites/libtests/telnetd01/telnetd01.doc
> > +++ /dev/null
> > @@ -1,24 +0,0 @@
> > -#
> > -# Copyright (c) 2018 embedded brains GmbH. All rights reserved.
> > -#
> > -# embedded brains GmbH
> > -# Dornierstr. 4
> > -# 82178 Puchheim
> > -# Germany
> > -# <rtems at embedded-brains.de>
> > -#
> > -# The license and distribution terms for this file may be
> > -# found in the file LICENSE in this distribution or at
> > -# http://www.rtems.org/license/LICENSE.
> > -
> > -This file describes the directives and concepts tested by this test set.
> > -
> > -test set name: telnetd01
> > -
> > -directives:
> > -
> > - - rtems_telnetd_start()
> > -
> > -concepts:
> > -
> > -+ Check if Telnet server works.
> > diff --git a/testsuites/libtests/telnetd01/telnetd01.scn b/testsuites/libtests/telnetd01/telnetd01.scn
> > deleted file mode 100644
> > index 3e9cc0007a..0000000000
> > --- a/testsuites/libtests/telnetd01/telnetd01.scn
> > +++ /dev/null
> > @@ -1,11 +0,0 @@
> > -*** BEGIN OF TEST TELNETD 1 ***
> > -*** TEST VERSION: 5.0.0.dc32b6aa0807fb70f9b26bc0bc6e164ddb49bd3a
> > -*** TEST STATE: EXPECTED_PASS
> > -*** TEST BUILD: RTEMS_NETWORKING
> > -*** TEST TOOLS: 7.3.0 20180125 (RTEMS 5, RSB 9670d7541e0621915e521fe76e7bb33de8cee661, Newlib d13c84eb07e35984bf7a974cd786a6cdac29e6b9)
> > -syslog: telnetd: configuration with invalid command
> > -syslog: telnetd: cannot create session task
> > -syslog: telnetd: started successfully on port 23
> > -syslog: telnetd: cannot bind server socket
> > -
> > -*** END OF TEST TELNETD 1 ***
> > --
> > 2.26.2
> >
More information about the devel
mailing list