[PATCH rtems 1/2] telnetd.c: Remove RTEMS_NETWORKING check

Gedare Bloom gedare at rtems.org
Thu Apr 22 18:21:01 UTC 2021


I guess there's not much else to do here without a network stack API
to manipulate the network task(s).

Is there a ticket to fix the lack of ability to configure and access
network task priorities? I'm guessing libbsd and lwip will both need
to figure out how to do this somehow. The design isn't obvious to me
right now.

On Thu, Apr 22, 2021 at 12:07 PM Vijay Kumar Banerjee <vijay at rtems.org> wrote:
>
> Ping :)
>
> On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee <vijay at rtems.org> wrote:
> >
> > Set the priority manually to make telnetd compatible with the
> > ---
> >  cpukit/telnetd/telnetd.c | 11 +----------
> >  1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/cpukit/telnetd/telnetd.c b/cpukit/telnetd/telnetd.c
> > index b8adec297a..7dad2f2f92 100644
> > --- a/cpukit/telnetd/telnetd.c
> > +++ b/cpukit/telnetd/telnetd.c
> > @@ -58,10 +58,6 @@
> >  #include <rtems/thread.h>
> >  #include <rtems/userenv.h>
> >
> > -#ifdef RTEMS_NETWORKING
> > -#include <rtems/rtems_bsdnet.h>
> > -#endif
> > -
> >  #define TELNETD_EVENT_SUCCESS RTEMS_EVENT_0
> >
> >  #define TELNETD_EVENT_ERROR RTEMS_EVENT_1
> > @@ -400,12 +396,7 @@ rtems_status_code rtems_telnetd_start(const rtems_telnetd_config_table* config)
> >    ctx->server_socket = -1;
> >    LIST_INIT(&ctx->free_sessions);
> >
> > -  /* Check priority */
> > -#ifdef RTEMS_NETWORKING
> > -  if (ctx->config.priority == 0) {
> > -    ctx->config.priority = rtems_bsdnet_config.network_task_priority;
> > -  }
> > -#endif
> > +  /* Set priority */
> >    if (ctx->config.priority == 0) {
> >      ctx->config.priority = 100;
> >    }
> > --
> > 2.26.2
> >


More information about the devel mailing list