[PATCH 2/2] c-user: Generate message manager documentation

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Apr 23 06:26:36 UTC 2021


On 22/04/2021 20:00, Gedare Bloom wrote:

> On Thu, Apr 22, 2021 at 11:33 AM Sebastian Huber
> <sebastian.huber at embedded-brains.de>  wrote:
>> On 22/04/2021 17:44, Gedare Bloom wrote:
>>
>>> Also not related to the documentation, but it seems that
>>> rtems_message_queue_construct() will not handle a NULL configuration.
>>> Is this intentional, or a bug to fix in the code and an error status
>>> to add? If it is intentional, an assert(config) should be added to the
>>> code path.
>>   From my point of view it was intentional to not check for NULL. I can
>> add an _Assert( config != NULL ) or return an error status.
>>
> assert makes sense to me at this level, it is a misuse of the API by the user.
Since we already have excessive NULL pointer checks in the Classic API, 
I changed it to return RTEMS_INVALID_ADDRESS if the configuration is 
NULL in rtems_task_construct() and rtems_message_queue_construct().
>
-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/



More information about the devel mailing list