[PATCH] riscv/start: Startup sequence update.

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Apr 29 17:53:15 UTC 2021


On 28/04/2021 15:55, Somesh Deshmukh wrote:
> +/* Clear .bss */
> +LADDR	a0, bsp_section_bss_begin
> +li	a1, 0
> +LADDR	a2, bsp_section_bss_size
> +call	memset
> +
>   #ifdef BSP_START_COPY_FDT_FROM_U_BOOT
>   	mv	a0, a1
>   	call	bsp_fdt_copy
>   #endif

How did you test this? The above memset() sets register a1 to 0 and 
probably uses this register also, the a1 is later used for the 
bsp_fdt_copy(), probably with an invalid value.

I would place the device tree in a noinit section.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/



More information about the devel mailing list