[PATCH v2 00/13] Remove app_common

[Chris Johns]

OK to push.

Chris

On 3/8/21 6:44 am, Ryan Long wrote:
> Hi,
> 
> In this iteration I:
> 
> - Removed the typedef in ObjdumpProcessor.h
> - Changed targetInfo to be a shared pointer
> - Got rid of some of the get & set methods for targetInfo_m
> - Added lastState_m to initialization list in ReportsHtml.cc
> 
> Thanks,
> Ryan
> 
> Ryan Long (13):
>   Remove AllExplanations global variable
>   ReportsHtml.cc: Initialize lastState_m
>   Remove objdumpProcessor global variable
>   Remove Verbose global variable
>   Remove dynamicLibrary global variable
>   Remove projectName global variable
>   Remove outputDirectory global variable
>   Remove input buffer global variables
>   Remove SymbolsToAnalyze global variable
>   Remove BranchInfoAvailable global variable
>   Remove TargetInfo global variable
>   app_common: Remove functions and macros
>   Remove app_common and all references to it
> 
>  tester/covoar/CoverageReaderBase.cc |   5 ++
>  tester/covoar/CoverageReaderBase.h  |  15 ++++
>  tester/covoar/CoverageReaderQEMU.cc |   7 +-
>  tester/covoar/CoverageReaderTSIM.cc |   5 +-
>  tester/covoar/DesiredSymbols.cc     |  28 +++---
>  tester/covoar/DesiredSymbols.h      |  27 ++++--
>  tester/covoar/ExecutableInfo.cc     |  23 ++---
>  tester/covoar/ExecutableInfo.h      |  17 +++-
>  tester/covoar/Explanations.cc       |  21 ++---
>  tester/covoar/GcovData.cc           |   7 +-
>  tester/covoar/GcovData.h            |  12 ++-
>  tester/covoar/GcovFunctionData.cc   |  15 ++--
>  tester/covoar/GcovFunctionData.h    |   6 +-
>  tester/covoar/Makefile              |   6 +-
>  tester/covoar/ObjdumpProcessor.cc   |  68 ++++++++++-----
>  tester/covoar/ObjdumpProcessor.h    | 113 +++++++++++++++---------
>  tester/covoar/ReportsBase.cc        | 166 +++++++++++++++++++++++-------------
>  tester/covoar/ReportsBase.h         |  69 +++++++++++++--
>  tester/covoar/ReportsHtml.cc        |  64 +++++++++-----
>  tester/covoar/ReportsHtml.h         |  10 ++-
>  tester/covoar/ReportsText.cc        |  28 ++++--
>  tester/covoar/ReportsText.h         |  10 ++-
>  tester/covoar/SymbolTable.cc        |   1 -
>  tester/covoar/TraceConverter.cc     |  39 ++++++---
>  tester/covoar/TraceReaderBase.h     |   7 +-
>  tester/covoar/TraceReaderLogQEMU.cc |  25 +++++-
>  tester/covoar/TraceReaderLogQEMU.h  |   6 +-
>  tester/covoar/TraceWriterBase.h     |   9 +-
>  tester/covoar/TraceWriterQEMU.cc    |  12 +--
>  tester/covoar/TraceWriterQEMU.h     |   4 +-
>  tester/covoar/app_common.cc         | 118 -------------------------
>  tester/covoar/app_common.h          |  34 --------
>  tester/covoar/coverage_converter.cc |   1 -
>  tester/covoar/covmerge.cc           |   8 +-
>  tester/covoar/covoar.cc             | 125 ++++++++++++++++++---------
>  tester/covoar/wscript               |   3 +-
>  36 files changed, 659 insertions(+), 455 deletions(-)
>  delete mode 100644 tester/covoar/app_common.cc
>  delete mode 100644 tester/covoar/app_common.h
>