[PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

Ryan Long ryan.long at oarcorp.com
Thu Aug 5 20:32:33 UTC 2021


We think that the best thing to do is to keep the ostream_guard in place and ignore the "Restore ostream format" issues.

-----Original Message-----
From: Chris Johns <chrisj at rtems.org> 
Sent: Wednesday, August 4, 2021 8:44 PM
To: Gedare Bloom <gedare at rtems.org>
Cc: Ryan Long <ryan.long at oarcorp.com>; devel at rtems.org
Subject: Re: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

On 5/8/21 9:13 am, Gedare Bloom wrote:
> On Wed, Aug 4, 2021 at 4:47 PM Chris Johns <chrisj at rtems.org> wrote:
>>
>> On 5/8/21 1:54 am, Ryan Long wrote:
>>> ostream_guard did not fix the "Not restoring ostream format" 
>>> Coverity issues as hoped, so there's no reason to have it.
>>
>> Can you capture the missing pieces here?
>>
> Also, just because it didn't fix coverity, doesn't mean it's a bad 
> thing to do. It seemed reasonable to me to save/restore the format so 
> it is unmodified across calls.

Yes, we should drive the design and not coverity.

Chris


More information about the devel mailing list