[PATCH 0/1] v3: Implementation of Condclockwait and Test

Matt Joyce mfjoyce2004 at gmail.com
Wed Aug 25 12:42:17 UTC 2021


Dr. Joel,

Please see my v3 attached for your review.

Major Changes:
1) Refactors condwaitsupp.c. Makes only one call to
set_timeout_argument(); gets clock from attributes then uses
that clock to make only one call to enqueue_with_timeout.

2) Defines CLOCK_NOT_SPECIFIED in condimpl.h, uses static assert
in condwaitsupp.c to ensure its value doesn't conflict with any
existing POSIX defined clocks. Uses this new value as a parameter
in condwait.c and condtimedwait.c

3) Removes all printf statements from psxcond03 test.

Standing by for any feedback...Thank you very much for your time!

Sincerely,

Matt

Matt Joyce (1):
  Added implementation / tests for pthread_cond_clockwait()

 cpukit/include/rtems/posix/condimpl.h         |   9 +-
 cpukit/posix/src/condclockwait.c              |  78 +++
 cpukit/posix/src/condtimedwait.c              |   3 +-
 cpukit/posix/src/condwait.c                   |   1 +
 cpukit/posix/src/condwaitsupp.c               | 108 +++-
 spec/build/testsuites/psxtests/grp.yml        |   2 +
 spec/build/testsuites/psxtests/psxcond03.yml  |  20 +
 testsuites/psxtests/Makefile.am               |   9 +
 testsuites/psxtests/configure.ac              |   1 +
 testsuites/psxtests/psxcond03/init.c          | 466 ++++++++++++++++++
 testsuites/psxtests/psxcond03/psxcond03.doc   |  44 ++
 testsuites/psxtests/psxcond03/psxcond03.scn   |   3 +
 testsuites/psxtests/psxcond03/system.h        |  61 +++
 .../psxhdrs/pthread/pthread_cond_clockwait.c  |   2 +-
 14 files changed, 786 insertions(+), 21 deletions(-)
 create mode 100644 cpukit/posix/src/condclockwait.c
 create mode 100644 spec/build/testsuites/psxtests/psxcond03.yml
 create mode 100644 testsuites/psxtests/psxcond03/init.c
 create mode 100644 testsuites/psxtests/psxcond03/psxcond03.doc
 create mode 100644 testsuites/psxtests/psxcond03/psxcond03.scn
 create mode 100644 testsuites/psxtests/psxcond03/system.h

-- 
2.31.1



More information about the devel mailing list