[PATCH rtems-tools 0/8] Convert and reformat pt. 4

Chris Johns chrisj at rtems.org
Tue Dec 7 21:30:22 UTC 2021


On 8/12/21 1:09 am, Ryan Long wrote:
> On 12/6/2021 10:09 PM, Chris Johns wrote:
>> On 4/12/21 1:47 am, Ryan Long wrote:
>>> Hi,
>>>
>>> For this series of patches, I followed this series of steps:
>>>
>>> 1. Convert a file from the C way of doing things to C++.
>>> 2. Go through all the files that had to do with the converted file and
>>> make the formatting consistent.
>> OK to push.
>>
>> It would be helpful in future to separate the white space changes from any code
>> changes.
> 
> I guess removing "void" from an empty parameter list and adding curly brackets
> around if statements counts as code changes? 

Yes.

> I didn't see any whitespace changes in the code changes.

The following is an example:

-    debug.begin(executable.elf());
+    debug.begin( executable.elf() );

It takes time for me to check and see if this is the same code with whitespace
changes or whitespace and code changes.

Chris


More information about the devel mailing list