[PATCH rtems-tools 5 2/5] rtemstoolkit: Filter mail options from log output

Alex White alex.white at oarcorp.com
Wed Dec 15 21:32:53 UTC 2021


This filters mail-related options out before logging the command line
options. This is needed to prevent leaking potentially sensitive
information via logs and emails.

Updates #4553
---
 rtemstoolkit/options.py | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/rtemstoolkit/options.py b/rtemstoolkit/options.py
index 32a7016..5ebe3bc 100644
--- a/rtemstoolkit/options.py
+++ b/rtemstoolkit/options.py
@@ -508,7 +508,22 @@ class command_line(object):
         return None
 
     def log_info(self):
-        log.output(log.info(self.argv))
+        # Filter potentially sensitive mail options out.
+        filtered_args = [
+            arg for arg in self.argv
+            if all(
+                smtp_opt not in arg
+                for smtp_opt in [
+                    '--smtp-host',
+                    '--mail-to',
+                    '--mail-from',
+                    '--smtp-user',
+                    '--smtp-password',
+                    '--smtp-port'
+                ]
+            )
+        ]
+        log.output(log.info(filtered_args))
 
 def load(opts):
     """
-- 
2.27.0



More information about the devel mailing list