[PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

Chris Johns chrisj at rtems.org
Sun Feb 14 21:20:28 UTC 2021


Hi Jan,

Thank you for the changes. I have one question inlined below ...

On 14/2/21 10:30 pm, Jan Sommer wrote:
> ---
>  bsps/include/dev/spi/cadence-spi-regs.h |  84 +++++
>  bsps/include/dev/spi/cadence-spi.h      |  48 +++
>  bsps/shared/dev/spi/cadence-spi.c       | 437 ++++++++++++++++++++++++
>  3 files changed, 569 insertions(+)
>  create mode 100644 bsps/include/dev/spi/cadence-spi-regs.h
>  create mode 100644 bsps/include/dev/spi/cadence-spi.h
>  create mode 100644 bsps/shared/dev/spi/cadence-spi.c
> 
> diff --git a/bsps/include/dev/spi/cadence-spi-regs.h b/bsps/include/dev/spi/cadence-spi-regs.h
> new file mode 100644
> index 0000000000..2851c88df1
> --- /dev/null
> +++ b/bsps/include/dev/spi/cadence-spi-regs.h
> @@ -0,0 +1,84 @@
> +/* SPDX-License-Identifier: BSD-2-Clause */
> +
> +/*
> + * Copyright (C) 2020 Jan Sommer, Deutsches Zentrum für Luft- und Raumfahrt e. V. 

Is there a unicode character in this line? I cannot see anything in our coding
standard about unicode characters in source and I am not sure what the actual
policy is. I seem to remember some have been removed in the past. I thought I
would ask on the list now before we push these changes.

Chris


More information about the devel mailing list