[PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

[Peter Dufault]

An international project should allow UTF in source code.  You might need to hunt what setting you need (for gnome-terminal "export LANG=en_US.UTF-8" works for me in the US).  I'm surprised if anyone is working on a system that can't at least display UTF-8.

> On Feb 15, 2021, at 03:21 , Jan.Sommer at dlr.de wrote:
> 
> Hi Chris,
> 
>> -----Original Message-----
>> From: Chris Johns <chrisj at rtems.org>
>> Sent: Sunday, February 14, 2021 10:20 PM
>> To: Sommer, Jan <Jan.Sommer at dlr.de>; devel at rtems.org
>> Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi
>> 
>> Hi Jan,
>> 
>> Thank you for the changes. I have one question inlined below ...
>> 
>> On 14/2/21 10:30 pm, Jan Sommer wrote:
>>> ---
>>> bsps/include/dev/spi/cadence-spi-regs.h |  84 +++++
>>> bsps/include/dev/spi/cadence-spi.h      |  48 +++
>>> bsps/shared/dev/spi/cadence-spi.c       | 437
>> ++++++++++++++++++++++++
>>> 3 files changed, 569 insertions(+)
>>> create mode 100644 bsps/include/dev/spi/cadence-spi-regs.h
>>> create mode 100644 bsps/include/dev/spi/cadence-spi.h
>>> create mode 100644 bsps/shared/dev/spi/cadence-spi.c
>>> 
>>> diff --git a/bsps/include/dev/spi/cadence-spi-regs.h
>>> b/bsps/include/dev/spi/cadence-spi-regs.h
>>> new file mode 100644
>>> index 0000000000..2851c88df1
>>> --- /dev/null
>>> +++ b/bsps/include/dev/spi/cadence-spi-regs.h
>>> @@ -0,0 +1,84 @@
>>> +/* SPDX-License-Identifier: BSD-2-Clause */
>>> +
>>> +/*
>>> + * Copyright (C) 2020 Jan Sommer, Deutsches Zentrum für Luft- und
>> Raumfahrt e. V.
>> 
>> Is there a unicode character in this line? I cannot see anything in our coding
>> standard about unicode characters in source and I am not sure what the
>> actual policy is. I seem to remember some have been removed in the past. I
>> thought I would ask on the list now before we push these changes.
>> 
> 
> There is an u-Umlaut in it. That is probably it. As it is part of the name, it's hard to get rid of.
> I could probably use the English name (German Aerospace Center) which has no special characters.
> Would that be preferred?
> 
> Best regards,
> 
>    Jan
> 
>> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel

Peter
-----------------
Peter Dufault
HD Associates, Inc.      Software and System Engineering

This email is delivered through the public internet using protocols subject to interception and tampering.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210215/4ef03e8f/attachment.bin>