[PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

[Jan.Sommer at dlr.de]

> -----Original Message-----
> From: devel <devel-bounces at rtems.org> On Behalf Of Chris Johns
> Sent: Tuesday, February 16, 2021 10:53 PM
> To: Gedare Bloom <gedare at rtems.org>; Peter Dufault <dufault at hda.com>
> Cc: devel at rtems.org
> Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi
> 
[...]
> > We haven't really made anything official policy, but I think the rule
> > is to avoid unicode unless there is a good reason for it.
> 
> We do not have a policy and I think we should.
> 
> I looked back and found the only discussion was about the sources for
> documentation:
> 
> https://lists.rtems.org/pipermail/devel/2019-February/052742.html
> 
> After that there is not a lot.
> 
> The doco thread prompted me to check patch 1/3 in this series and saved the
> email. The text in it was a large long box of ascii encoding of some form. I
> applied the patch using git as test and git is fine with this which is neat and
> the unicode characters appeared in the git log as:
> 
> +/*
> + * Copyright (C) 2020 Jan Sommer, Deutsches Zentrum f<C3><BC>r Luft-
> +und
> Raumfahrt e. V. (DLR)
> + *
> 
> Less and vi both has similar things ...
> 
>  * Copyright (C) 2020 Jan Sommer, Deutsches Zentrum f\xc3\xbcr Luft- und
> Raumfahrt e. V. (DLR)
> 

That's strange. 
I also do my development in terminal. Less, cat and other CLI tools show the characters fine.


> The issue for terminal level work discussed in the doco source is present but
> in terms of formal names I am fine with there being unicode characters. I
> think having a formal name written in its proper form is what we should
> allow. The use of unicode in comments or code is different and here we
> need to accept the low common denominator which looks like me on a text
> terminal.
> 

Sounds reasonable to me.

Best regards,

    Jan

> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel