[PATCH v1 2/2] bsps/aarch64: Resolve usage of SUBALIGN()

[Sebastian Huber]

Hello Kinsey,

could you please split up the patches. One for the linker command file 
and one for the linkersets.h.

On 18/02/2021 19:59, Kinsey Moore wrote:
> diff --git a/cpukit/include/rtems/linkersets.h b/cpukit/include/rtems/linkersets.h
> index d3ed76043a..fce6676e4a 100644
> --- a/cpukit/include/rtems/linkersets.h
> +++ b/cpukit/include/rtems/linkersets.h
> @@ -27,36 +27,39 @@ extern "C" {
>   #define RTEMS_LINKER_SET_END( set ) \
>     _Linker_set_##set##_end
>   
> +#define RTEMS_LINKER_ALIGN( type ) \
> +  __attribute__((__aligned__(_Alignof(type))))

Please use RTEMS_ALIGN() and the new RTEMS_ALIGNOF() which works also 
for C++.

It should be named RTEMS_LINKER_SET_ALIGN(). Please add a comment why it 
is necessary. I guess for a random reviewer things like this

RTEMS_LINKER_ALIGN(type) extern type

make no sense without a comment.

Please add spaces, e.g. RTEMS_LINKER_ALIGN( type ).

I would put the type and the alignment together, e.g.

extern RTEMS_LINKER_ALIGN( type ) type

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/