[PATCH rtems] bsps/imxrt: Add attribution in file headers
Chris Johns
chrisj at rtems.org
Wed Jul 21 00:46:08 UTC 2021
On 21/7/21 6:47 am, Gedare Bloom wrote:
> This seems fine to me. We don't have any standard way to document this
> kind of attribution. However, we have had individual authors add their
> names below their company's copyright. It might make sense to put the
> sponsorship part beneath the copyright of the sponsored
> company/person?
Make sense. The copyright block should be limited to just copyrights and sponsor
acknowledgements should in a separate block, maybe after the license block.
> Not a big deal, but it might help for some kind of
> consistent guidance if we do this more in the future.
I think we need some guidelines. I do not agree with URL links, email addresses,
phone numbers or street addreses appearing in the source. I also think a sponsor
acknowledgement is never updated or changed even if a company changes name. What
I am not sure about is the areas of the source we allow this to happen in, ie
score ...?
Chris
>
> On Tue, Jul 20, 2021 at 8:20 AM Christian Mauderer
> <christian.mauderer at embedded-brains.de> wrote:
>>
>> Onto Innovations Incorporated originally sponsored the development of
>> this BSP. This patch adds the attribution for it.
>>
>> The patch also fixes an old license header in bspstarthooks.c that was
>> accidentally copied into that file.
>> ---
>> bsps/arm/imxrt/console/console.c | 1 +
>> bsps/arm/imxrt/dts/imxrt1050-evkb.dts | 2 ++
>> bsps/arm/imxrt/i2c/imxrt-lpi2c.c | 1 +
>> bsps/arm/imxrt/include/bsp.h | 1 +
>> bsps/arm/imxrt/include/bsp/flash-headers.h | 1 +
>> bsps/arm/imxrt/include/bsp/irq.h | 1 +
>> bsps/arm/imxrt/include/fsl_device_registers.h | 1 +
>> .../imxrt/include/imxrt/imxrt1050-pinfunc.h | 1 +
>> bsps/arm/imxrt/include/imxrt/imxrt1050.dtsi | 2 ++
>> bsps/arm/imxrt/include/imxrt/lpspi.h | 1 +
>> bsps/arm/imxrt/include/imxrt/memory.h | 1 +
>> bsps/arm/imxrt/include/imxrt/mpu-config.h | 1 +
>> bsps/arm/imxrt/spi/imxrt-lpspi.c | 1 +
>> bsps/arm/imxrt/start/bspstart.c | 1 +
>> bsps/arm/imxrt/start/bspstarthooks.c | 32 +++++++++++++------
>> bsps/arm/imxrt/start/clock-arm-pll-config.c | 1 +
>> bsps/arm/imxrt/start/flash-boot-data.c | 1 +
>> bsps/arm/imxrt/start/flash-flexspi-config.c | 1 +
>> bsps/arm/imxrt/start/flash-ivt.c | 1 +
>> bsps/arm/imxrt/start/imxrt-ffec-init.c | 1 +
>> bsps/arm/imxrt/start/mpu-config.c | 1 +
>> 21 files changed, 45 insertions(+), 9 deletions(-)
>>
>> diff --git a/bsps/arm/imxrt/console/console.c b/bsps/arm/imxrt/console/console.c
>> index 05320f2c4c..ab278b9d22 100644
>> --- a/bsps/arm/imxrt/console/console.c
>> +++ b/bsps/arm/imxrt/console/console.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/dts/imxrt1050-evkb.dts b/bsps/arm/imxrt/dts/imxrt1050-evkb.dts
>> index 9310371428..bf24762d86 100644
>> --- a/bsps/arm/imxrt/dts/imxrt1050-evkb.dts
>> +++ b/bsps/arm/imxrt/dts/imxrt1050-evkb.dts
>> @@ -1,7 +1,9 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> + *
>> * Redistribution and use in source and binary forms, with or without
>> * modification, are permitted provided that the following conditions
>> * are met:
>> diff --git a/bsps/arm/imxrt/i2c/imxrt-lpi2c.c b/bsps/arm/imxrt/i2c/imxrt-lpi2c.c
>> index 783c6e18e6..0873499a24 100644
>> --- a/bsps/arm/imxrt/i2c/imxrt-lpi2c.c
>> +++ b/bsps/arm/imxrt/i2c/imxrt-lpi2c.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/bsp.h b/bsps/arm/imxrt/include/bsp.h
>> index f93c28aee0..78fa6a42e1 100644
>> --- a/bsps/arm/imxrt/include/bsp.h
>> +++ b/bsps/arm/imxrt/include/bsp.h
>> @@ -7,6 +7,7 @@
>> */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/bsp/flash-headers.h b/bsps/arm/imxrt/include/bsp/flash-headers.h
>> index 6575b1c21b..a50ae68d58 100644
>> --- a/bsps/arm/imxrt/include/bsp/flash-headers.h
>> +++ b/bsps/arm/imxrt/include/bsp/flash-headers.h
>> @@ -9,6 +9,7 @@
>> */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/bsp/irq.h b/bsps/arm/imxrt/include/bsp/irq.h
>> index 6fcd055f03..52de519471 100644
>> --- a/bsps/arm/imxrt/include/bsp/irq.h
>> +++ b/bsps/arm/imxrt/include/bsp/irq.h
>> @@ -7,6 +7,7 @@
>> */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/fsl_device_registers.h b/bsps/arm/imxrt/include/fsl_device_registers.h
>> index 00c3fc7036..6a57397789 100644
>> --- a/bsps/arm/imxrt/include/fsl_device_registers.h
>> +++ b/bsps/arm/imxrt/include/fsl_device_registers.h
>> @@ -9,6 +9,7 @@
>> */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/imxrt/imxrt1050-pinfunc.h b/bsps/arm/imxrt/include/imxrt/imxrt1050-pinfunc.h
>> index 16ebfae5b3..439b0c5384 100644
>> --- a/bsps/arm/imxrt/include/imxrt/imxrt1050-pinfunc.h
>> +++ b/bsps/arm/imxrt/include/imxrt/imxrt1050-pinfunc.h
>> @@ -9,6 +9,7 @@
>> */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/imxrt/imxrt1050.dtsi b/bsps/arm/imxrt/include/imxrt/imxrt1050.dtsi
>> index 69095fea23..9f184886b4 100644
>> --- a/bsps/arm/imxrt/include/imxrt/imxrt1050.dtsi
>> +++ b/bsps/arm/imxrt/include/imxrt/imxrt1050.dtsi
>> @@ -1,7 +1,9 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> + *
>> * Redistribution and use in source and binary forms, with or without
>> * modification, are permitted provided that the following conditions
>> * are met:
>> diff --git a/bsps/arm/imxrt/include/imxrt/lpspi.h b/bsps/arm/imxrt/include/imxrt/lpspi.h
>> index 8a87f28da9..a5162b4c04 100644
>> --- a/bsps/arm/imxrt/include/imxrt/lpspi.h
>> +++ b/bsps/arm/imxrt/include/imxrt/lpspi.h
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/imxrt/memory.h b/bsps/arm/imxrt/include/imxrt/memory.h
>> index 47bb10f41e..e017622760 100644
>> --- a/bsps/arm/imxrt/include/imxrt/memory.h
>> +++ b/bsps/arm/imxrt/include/imxrt/memory.h
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/include/imxrt/mpu-config.h b/bsps/arm/imxrt/include/imxrt/mpu-config.h
>> index d26d03ab33..25bd657929 100644
>> --- a/bsps/arm/imxrt/include/imxrt/mpu-config.h
>> +++ b/bsps/arm/imxrt/include/imxrt/mpu-config.h
>> @@ -9,6 +9,7 @@
>> */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/spi/imxrt-lpspi.c b/bsps/arm/imxrt/spi/imxrt-lpspi.c
>> index 06d8f715d9..874af5dbd4 100644
>> --- a/bsps/arm/imxrt/spi/imxrt-lpspi.c
>> +++ b/bsps/arm/imxrt/spi/imxrt-lpspi.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/bspstart.c b/bsps/arm/imxrt/start/bspstart.c
>> index 445af04563..19db73bb4a 100644
>> --- a/bsps/arm/imxrt/start/bspstart.c
>> +++ b/bsps/arm/imxrt/start/bspstart.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/bspstarthooks.c b/bsps/arm/imxrt/start/bspstarthooks.c
>> index b8149691e7..54b464ba76 100644
>> --- a/bsps/arm/imxrt/start/bspstarthooks.c
>> +++ b/bsps/arm/imxrt/start/bspstarthooks.c
>> @@ -1,15 +1,29 @@
>> +/* SPDX-License-Identifier: BSD-2-Clause */
>> +
>> /*
>> - * Copyright (c) 2013, 2018 embedded brains GmbH. All rights reserved.
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> + * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> - * embedded brains GmbH
>> - * Dornierstr. 4
>> - * 82178 Puchheim
>> - * Germany
>> - * <info at embedded-brains.de>
>> + * Redistribution and use in source and binary forms, with or without
>> + * modification, are permitted provided that the following conditions
>> + * are met:
>> + * 1. Redistributions of source code must retain the above copyright
>> + * notice, this list of conditions and the following disclaimer.
>> + * 2. Redistributions in binary form must reproduce the above copyright
>> + * notice, this list of conditions and the following disclaimer in the
>> + * documentation and/or other materials provided with the distribution.
>> *
>> - * The license and distribution terms for this file may be
>> - * found in the file LICENSE in this distribution or at
>> - * http://www.rtems.org/license/LICENSE.
>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
>> + * POSSIBILITY OF SUCH DAMAGE.
>> */
>>
>> #include <rtems/score/armv7m.h>
>> diff --git a/bsps/arm/imxrt/start/clock-arm-pll-config.c b/bsps/arm/imxrt/start/clock-arm-pll-config.c
>> index 12ad1867eb..96a5944b7b 100644
>> --- a/bsps/arm/imxrt/start/clock-arm-pll-config.c
>> +++ b/bsps/arm/imxrt/start/clock-arm-pll-config.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2021 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/flash-boot-data.c b/bsps/arm/imxrt/start/flash-boot-data.c
>> index a1877f4d26..50f87fbb5c 100644
>> --- a/bsps/arm/imxrt/start/flash-boot-data.c
>> +++ b/bsps/arm/imxrt/start/flash-boot-data.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/flash-flexspi-config.c b/bsps/arm/imxrt/start/flash-flexspi-config.c
>> index 50eca19b20..f8512154c4 100644
>> --- a/bsps/arm/imxrt/start/flash-flexspi-config.c
>> +++ b/bsps/arm/imxrt/start/flash-flexspi-config.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/flash-ivt.c b/bsps/arm/imxrt/start/flash-ivt.c
>> index fd396d5e1a..139fce724d 100644
>> --- a/bsps/arm/imxrt/start/flash-ivt.c
>> +++ b/bsps/arm/imxrt/start/flash-ivt.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/imxrt-ffec-init.c b/bsps/arm/imxrt/start/imxrt-ffec-init.c
>> index 4b71944c00..50348f3652 100644
>> --- a/bsps/arm/imxrt/start/imxrt-ffec-init.c
>> +++ b/bsps/arm/imxrt/start/imxrt-ffec-init.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> diff --git a/bsps/arm/imxrt/start/mpu-config.c b/bsps/arm/imxrt/start/mpu-config.c
>> index 79800ac431..893d5c4cc2 100644
>> --- a/bsps/arm/imxrt/start/mpu-config.c
>> +++ b/bsps/arm/imxrt/start/mpu-config.c
>> @@ -1,6 +1,7 @@
>> /* SPDX-License-Identifier: BSD-2-Clause */
>>
>> /*
>> + * i.MX RT port sponsored by Onto Innovation Incorporated
>> * Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>> *
>> * Redistribution and use in source and binary forms, with or without
>> --
>> 2.26.2
>>
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
More information about the devel
mailing list