[PATCH rtems] bsps/imxrt: Add attribution in file headers

Christian MAUDERER christian.mauderer at embedded-brains.de
Wed Jul 21 07:05:00 UTC 2021


Hello,

I don't object to clear rules. At the moment it's a bit of a mix. Some 
examples of what I have found (mainly in PowerPC):

Above the copyright line:

https://git.rtems.org/rtems/tree/bsps/powerpc/ss555/start/vectors.S
https://git.rtems.org/rtems/tree/bsps/powerpc/ss555/start/vectors_init.c
https://git.rtems.org/rtems/tree/bsps/powerpc/ss555/start/irq.c
https://git.rtems.org/rtems/tree/bsps/powerpc/include/libcpu/irq.h

Mixed in the header somewhere:

https://git.rtems.org/rtems/tree/bsps/powerpc/ss555/start/bspstart.c


Am 21.07.21 um 07:51 schrieb Sebastian Huber:
> On 21/07/2021 02:46, Chris Johns wrote:
>> On 21/7/21 6:47 am, Gedare Bloom wrote:
>>> This seems fine to me. We don't have any standard way to document this
>>> kind of attribution. However, we have had individual authors add their
>>> names below their company's copyright. It might make sense to put the
>>> sponsorship part beneath the copyright of the sponsored
>>> company/person?
>>
>> Make sense. The copyright block should be limited to just copyrights 
>> and sponsor
>> acknowledgements should in a separate block, maybe after the license 
>> block.
> 
> Yes, I also think it should be outside the license comment block.
> 
>>
>>> Not a big deal, but it might help for some kind of
>>> consistent guidance if we do this more in the future.
>>
>> I think we need some guidelines. I do not agree with URL links, email 
>> addresses,
>> phone numbers or street addreses appearing in the source. I also think 
>> a sponsor
>> acknowledgement is never updated or changed even if a company changes 
>> name. What
>> I am not sure about is the areas of the source we allow this to happen 
>> in, ie
>> score ...?
> 
> We could add some text here:
> 
> https://docs.rtems.org/branches/master/eng/coding-file-hdr.html
> 

Without discussing it with Onto: An alternative to attribution in the 
code could be an attribution page in the manuals where we can collect 
such notes. That would avoid scattering them throughout the code. It 
would also make it easier to (for example) attribute to supporters that 
maybe don't fund coding but other activities like infrastructure.

We could add "User Applications" in a similar section. At the moment 
these are in a TBR wiki area: https://devel.rtems.org/wiki/TBR/UserApp

Best regards

Christian
-- 
--------------------------------------------
embedded brains GmbH
Herr Christian MAUDERER
Dornierstr. 4
82178 Puchheim
Germany
email: christian.mauderer at embedded-brains.de
phone: +49-89-18 94 741 - 18
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list