[PATCH] score: Canonicalize _CPU_Fatal_halt()

Joel Sherrill joel at rtems.org
Wed Jul 28 14:05:39 UTC 2021


On Wed, Jul 28, 2021 at 8:45 AM Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
>
> On 28/07/2021 15:42, Joel Sherrill wrote:
> > In reviewing horizontally, I see one implementation that calls
> > printk(). Is that necessary and of value now?
>
> I was a bit unsure about this one. The default implementation is:
>
> void _CPU_Fatal_halt( uint32_t source, CPU_Uint32ptr error )
> {
>    ISR_Level level;
>
>    _CPU_ISR_Disable( level );
>    (void) level;
>
>    while ( true ) {
>      /* Do nothing */
>    }
> }
>
> Should I remove the printk() variant and replace it with this?

I'd be ok with that. Now that we have the nice way to print on _Terminate.

>
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber at embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list