[PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

Gedare Bloom gedare at rtems.org
Wed Jul 28 14:27:04 UTC 2021


On Wed, Jul 28, 2021 at 12:50 AM Chris Johns <chrisj at rtems.org> wrote:
>
> On 28/7/21 4:38 pm, Sebastian Huber wrote:
> > On 28/07/2021 04:53, chrisj at rtems.org wrote:
> >> +        for sym in self.output['symbols']:
> >> +            out += ['#define %s_bsd_%s' % (sym, sym)]
> >
> > If you add a tab after the #define, then the output is in line with the FreeBSD
> > style and you have a lot less changes in the generated file compared to the
> > previous script.
>
> You have lost me on the FreeBSD style so I am moving on.
>
I think the suggestion is to use
out += ['#define\t%s_bsd_%s' % (sym, sym)]

> In regards to diff'ing the file the sort order was something bespoke to Linux's
> sort and so all the defines moved about anyway. I check all the symbols present
> before are present in the generated file. I also checked the executables from
> before and after regeneration matched.
>
> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list