[PATCH v2 2/2] i386: Remove unneeded include header files

[Jan.Sommer at dlr.de]

> -----Original Message-----
> From: Gedare Bloom <gedare at rtems.org>
> Sent: Wednesday, June 9, 2021 8:33 PM
> To: Sommer, Jan <Jan.Sommer at dlr.de>
> Cc: Amar Takhar <verm at darkbeer.org>; Chris Johns <chrisj at rtems.org>;
> devel at rtems.org
> Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files
> 
> On Wed, Jun 9, 2021 at 12:27 PM Gedare Bloom <gedare at rtems.org> wrote:
> >
> > On Wed, Jun 9, 2021 at 12:21 PM Gedare Bloom <gedare at rtems.org>
> wrote:
> > >
> > > It is helpful. there should be
> > > remote: 3: update trac
> > >
> > ok, actually what's missing is
> > 0: init
> >
> > I think the hooks need to be updated for rtems-libbsd. without running
> > init, the TMP_REV is not generated, so there's nothing to send to
> > trac.
> >
> > I'm going to update the hooks, and we'll see if it works next time.
> > You'll need to manually close the ticket(s) for 5.
> >
> It seems like tickets were being closed for the 6-freebsd-12 branch, so now
> I'm not actually sure this is the right fix, or why they were working without
> the init step. We may need to do some testing.
> 
I didn't create ticket for the 6-freebsd-12 branch. Should I have?
The output of git push looks quite similar:

$ git push upstream HEAD~:6-freebsd-12
Counting objects: 4, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 627 bytes | 627.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: 1: mail vc at rtems.org
remote: 2: update github
remote: 4: IRC
remote: usage: <file with rev-list> <repo name without .git>
remote: 5: Buildbot
To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git
   34862dd273..1ca0dc7309  HEAD~ -> 6-freebsd-12

> > > now we need to find out why. seems the problem really is on git side.
> > >
> > > On Wed, Jun 9, 2021 at 12:03 PM <Jan.Sommer at dlr.de> wrote:
> > > >
> > > > That`s the output I got.
> > > > Not sure if it is helpful:
> > > >
> > > > $ git push upstream HEAD~:5-freebsd-12 Counting objects: 4, done.
> > > > Delta compression using up to 8 threads.
> > > > Compressing objects: 100% (4/4), done.
> > > > Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done.
> > > > Total 4 (delta 3), reused 0 (delta 0)
> > > > remote: 1: mail vc at rtems.org
> > > > remote: 2: update github
> > > > remote: 4: IRC
> > > > remote: usage: <file with rev-list> <repo name without .git>
> > > > remote: 5: Buildbot
> > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git
> > > >    a2bc8eba46..9edb1201f6  HEAD~ -> 5-freebsd-12
> > > >
> > > > $ git push upstream HEAD:5-freebsd-12 Counting objects: 7, done.
> > > > Delta compression using up to 8 threads.
> > > > Compressing objects: 100% (6/6), done.
> > > > Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done.
> > > > Total 7 (delta 4), reused 0 (delta 0)
> > > > remote: 1: mail vc at rtems.org
> > > > remote: 2: update github
> > > > remote: 4: IRC
> > > > remote: usage: <file with rev-list> <repo name without .git>
> > > > remote: 5: Buildbot
> > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git
> > > >    9edb1201f6..5c1b99e4d2  HEAD -> 5-freebsd-12
> > > >
> > > > > -----Original Message-----
> > > > > From: Gedare Bloom <gedare at rtems.org>
> > > > > Sent: Wednesday, June 9, 2021 7:59 PM
> > > > > To: Sommer, Jan <Jan.Sommer at dlr.de>; Amar Takhar
> > > > > <verm at darkbeer.org>
> > > > > Cc: Chris Johns <chrisj at rtems.org>; devel at rtems.org
> > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header
> > > > > files
> > > > >
> > > > > On Wed, Jun 9, 2021 at 10:51 AM <Jan.Sommer at dlr.de> wrote:
> > > > > >
> > > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12.
> > > > > > Short question: Does the buildbot recognize the pushes to
> > > > > > rtems-libbsd/5-
> > > > > freebsd-12 and update the ticket?
> > > > > > I added the ticket number to the commit description, but the
> > > > > > ticket has not
> > > > > been updated.
> > > > > >
> > > > > Do you still have the terminal output from running git-push?
> > > > >
> > > > > The git side looks ok, but I can't check the trac end.
> > > > >
> > > > > > Best regards,
> > > > > >
> > > > > >     Jan
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Chris Johns <chrisj at rtems.org>
> > > > > > > Sent: Wednesday, June 9, 2021 12:13 PM
> > > > > > > To: Sommer, Jan <Jan.Sommer at dlr.de>; gedare at rtems.org
> > > > > > > Cc: devel at rtems.org
> > > > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include
> > > > > > > header files
> > > > > > >
> > > > > > > On 8/6/21 11:52 pm, Jan.Sommer at dlr.de wrote:
> > > > > > > > I would also like to backport this to 5-freebsd-12 to
> > > > > > > > solve this issue
> > > > > there as
> > > > > > > well.
> > > > > > > > I created a corresponding ticket:
> > > > > > > https://devel.rtems.org/ticket/4452#ticket
> > > > > > >
> > > > > > > OK for 5.
> > > > > > >
> > > > > > > Chris