[PATCH 1/3] cpukit/libmisc/rtems-ftd: Fixed error of null pointer dereference in rtems-fdt.c

[Joel Sherrill]

This definitely moves the dereference before the free() so appears to be OK.

If Gedare approves, he can merge it.

--joel

On Tue, Jun 29, 2021 at 2:54 PM Harrison Edward Gerber
<gerberhe11 at gmail.com> wrote:
>
> See Also CID 1437647
>
> Closes #4460
> ---
>  cpukit/libmisc/rtems-fdt/rtems-fdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c b/cpukit/libmisc/rtems-fdt/rtems-fdt.c
> index 7747ba9bf8..bfbc6102a2 100644
> --- a/cpukit/libmisc/rtems-fdt/rtems-fdt.c
> +++ b/cpukit/libmisc/rtems-fdt/rtems-fdt.c
> @@ -678,14 +678,14 @@ rtems_fdt_unload (rtems_fdt_handle* handle)
>
>    rtems_chain_extract_unprotected (&handle->blob->node);
>
> +  rtems_fdt_release_index(&handle->blob->index);
> +
>    free (handle->blob);
>
>    handle->blob = NULL;
>
>    rtems_fdt_unlock (fdt);
>
> -  rtems_fdt_release_index(&handle->blob->index);
> -
>    return 0;
>  }
>
> --
> 2.25.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel