[PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

[Gedare Bloom]

On Mon, Mar 1, 2021 at 9:24 AM Ryan Long <thisisryanlong at gmail.com> wrote:
>
> CID 1047324: Unchecked return value in fdt_add_subnode_namelen().
>
> Updates #4256
> ---
>  cpukit/dtc/libfdt/fdt_rw.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c
I think it was suggested to attempt to provide this in the upstream for dtc?

> index 1385425..d6f7d93 100644
> --- a/cpukit/dtc/libfdt/fdt_rw.c
> +++ b/cpukit/dtc/libfdt/fdt_rw.c
> @@ -348,7 +348,11 @@ int fdt_add_subnode_namelen(void *fdt, int parentoffset,
>                 return offset;
>
>         /* Try to place the new node after the parent's properties */
> -       fdt_next_tag(fdt, parentoffset, &nextoffset); /* skip the BEGIN_NODE */
> +        #ifdef __rtems__
> +         (void)fdt_next_tag(fdt, parentoffset, &nextoffset); /* skip the BEGIN_NODE */
I think we usually put a space after (void)
(void) fdt...

but, it should be consistent with the upstream

> +        #else
> +          fdt_next_tag(fdt, parentoffset, &nextoffset);
> +        #endif
>         do {
>                 offset = nextoffset;
>                 tag = fdt_next_tag(fdt, offset, &nextoffset);
> --
> 1.8.3.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel