[PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

Gedare Bloom gedare at rtems.org
Mon Mar 1 19:35:01 UTC 2021


On Mon, Mar 1, 2021 at 12:26 PM Ryan Long <ryan.long at oarcorp.com> wrote:
>
> So just send this patch to them?
>
Without the ifdef construct

> -----Original Message-----
> From: devel <devel-bounces at rtems.org> On Behalf Of Gedare Bloom
> Sent: Monday, March 1, 2021 1:03 PM
> To: Sebastian Huber <sebastian.huber at embedded-brains.de>
> Cc: Ryan Long <thisisryanlong at gmail.com>; devel at rtems.org
> Subject: Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)
>
> On Mon, Mar 1, 2021 at 11:49 AM Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:
> >
> > On 01/03/2021 17:56, Gedare Bloom wrote:
> >
> > > On Mon, Mar 1, 2021 at 9:24 AM Ryan Long<thisisryanlong at gmail.com>  wrote:
> > >> CID 1047324: Unchecked return value in fdt_add_subnode_namelen().
> > >>
> > >> Updates #4256
> > >> ---
> > >>   cpukit/dtc/libfdt/fdt_rw.c | 6 +++++-
> > >>   1 file changed, 5 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/cpukit/dtc/libfdt/fdt_rw.c
> > >> b/cpukit/dtc/libfdt/fdt_rw.c
> > > I think it was suggested to attempt to provide this in the upstream for dtc?
> > Yes, please at least report the issue upstream and send a patch to
> > their mailing list. They are usually quite responsive.
> >
> +1  send the patch to them before we consider including it in rtems.
>
> > --
> > embedded brains GmbH
> > Herr Sebastian HUBER
> > Dornierstr. 4
> > 82178 Puchheim
> > Germany
> > email: sebastian.huber at embedded-brains.de
> > phone: +49-89-18 94 741 - 16
> > fax:   +49-89-18 94 741 - 08
> >
> > Registergericht: Amtsgericht München
> > Registernummer: HRB 157899
> > Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas
> > Dörfler Unsere Datenschutzerklärung finden Sie hier:
> > https://embedded-brains.de/datenschutzerklaerung/
> >
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list