[PATCH 00/12] Fix Unchecked return value from library errors

Gedare Bloom gedare at rtems.org
Thu Mar 4 16:26:37 UTC 2021


separate all the grlib/gr device driver fixes, and submit them as a
separate patch set for review/approval by Daniel. We may need to
collect a set of these and poke him, but we want to make sure we keep
some consistency with them, in case they have any patches outside our
tree waiting to merge. (just a little bit of good citizenship)

On Thu, Mar 4, 2021 at 7:05 AM Ryan Long <thisisryanlong at gmail.com> wrote:
>
> Hi,
>
> Here are the fixes for the "Unchecked return value from library"
> Coverity errors. For most of these, I added a status code variable,
> returned the value, and used the _Assert_Unused_variable_equal/unequal
> macros. For main_help.c, a (void) was just added because we don't care
> about the value that is returned.
>
> Ryan
>
> Ryan Long (12):
>   gen_uuid.c: Fix two Unchecked return value from library errors
>   main_chmod.c: Fix Unchecked return value from library (CID #1063856)
>   pwdgrp.c: Fix Unchecked return value from library (CID #1255518)
>   gr_rasta_spw_router.c: Fix Unchecked return value from library (CID
>     #1399760)
>   gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)
>   gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)
>   gr_rasta_tmtc.c: Fix Unchecked return value from library (CID
>     #1399771)
>   gr_rasta_tmtc.c: Fix Unchecked return value from library (CID
>     #1399780)
>   gr_701.c: Unchecked return value from library (CID #1399783)
>   gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)
>   gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)
>   main_help.c: Unchecked return value from library (CID #1437650)
>
>  bsps/shared/grlib/pci/gr_701.c              |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_adcdac.c     |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_io.c         |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_spw_router.c |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_tmtc.c       |  4 +++-
>  bsps/shared/grlib/pci/gr_tmtc_1553.c        |  4 +++-
>  bsps/sparc/shared/pci/gr_cpci_gr740.c       |  4 +++-
>  bsps/sparc/shared/pci/gr_leon4_n2x.c        |  4 +++-
>  cpukit/libcsupport/src/pwdgrp.c             |  6 +++++-
>  cpukit/libmisc/shell/main_chmod.c           |  5 ++++-
>  cpukit/libmisc/shell/main_help.c            |  3 ++-
>  cpukit/libmisc/uuid/gen_uuid.c              | 12 ++++++++++--
>  12 files changed, 45 insertions(+), 13 deletions(-)
>
> --
> 1.8.3.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list