[PATCH 00/12] Fix grlib/gr device driver Coverity errors

[Gedare Bloom]

Hi Daniel,

Can you have a look at these patches, and the follow-up one with the
/* fall-through */ comments? Do you guys host your own version that
you would like to keep synch'ed with the one in RTEMS, or how would
you like to handle patches to grlib / gr drivers in rtems?

Thanks,
Gedare

On Thu, Mar 4, 2021 at 12:50 PM Ryan Long <thisisryanlong at gmail.com> wrote:
>
> Hi,
>
> Here are the fixes for the Coverity errors with grlib/gr device drivers.
>
> The types of issues fixed were:
> - Unchecked return value
> - Unchecked return value from library
> - Unsigned compared against 0
> - Unused value
>
> For the "Unsigned compared against 0" errors in satcan.c, the first if
> statements were not being used, so they were taken out.
>
> Thanks,
> Ryan
>
> Ryan Long (12):
>   grspw.c: Fix Unchecked return value (CID #1399781)
>   gr_rasta_spw_router.c: Fix Unchecked return value from library (CID
>     #1399760)
>   gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)
>   gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)
>   gr_rasta_tmtc.c: Fix Unchecked return value from library (CID
>     #1399771)
>   gr_rasta_tmtc.c: Fix Unchecked return value from library (CID
>     #1399780)
>   gr_701.c: Unchecked return value from library (CID #1399783)
>   gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)
>   gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)
>   satcan.c: Fix Unsigned compared against 0 (CID #1399768)
>   b1553brm.c: Fix Unsigned compared against 0 (CID #1399773)
>   grcan.c: Fix Unused value (CID #1437613)
>
>  bsps/shared/grlib/1553/b1553brm.c           |  2 +-
>  bsps/shared/grlib/can/grcan.c               |  2 +-
>  bsps/shared/grlib/can/satcan.c              | 16 ++++------------
>  bsps/shared/grlib/pci/gr_701.c              |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_adcdac.c     |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_io.c         |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_spw_router.c |  4 +++-
>  bsps/shared/grlib/pci/gr_rasta_tmtc.c       |  4 +++-
>  bsps/shared/grlib/pci/gr_tmtc_1553.c        |  4 +++-
>  bsps/shared/grlib/spw/grspw.c               |  7 +++++--
>  bsps/sparc/shared/pci/gr_cpci_gr740.c       |  4 +++-
>  bsps/sparc/shared/pci/gr_leon4_n2x.c        |  4 +++-
>  12 files changed, 35 insertions(+), 24 deletions(-)
>
> --
> 1.8.3.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel