[PATCH v3 2/2] bsps/aarch64: Resolve usage of SUBALIGN()

Gedare Bloom gedare at rtems.org
Fri Mar 5 15:19:58 UTC 2021


This one seems fine to me based on my understanding of the rtemsr*set
explicit alignment change.

On Wed, Mar 3, 2021 at 6:37 AM Kinsey Moore <kinsey.moore at oarcorp.com> wrote:
>
> Remove usage of SUBALIGN() in aarch64 linkcmds which works around a
> difference in behavior on AArch64 platforms. This is no longer necessary
> since alignment is now enforced explicitly.
>
> Closes #4178.
> ---
>  bsps/aarch64/shared/start/linkcmds.base | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bsps/aarch64/shared/start/linkcmds.base b/bsps/aarch64/shared/start/linkcmds.base
> index 294390870a..1768ed001a 100644
> --- a/bsps/aarch64/shared/start/linkcmds.base
> +++ b/bsps/aarch64/shared/start/linkcmds.base
> @@ -245,7 +245,7 @@ SECTIONS {
>         .got : ALIGN_WITH_INPUT {
>                 *(.got.plt) *(.igot.plt) *(.got) *(.igot)
>         } > REGION_RODATA AT > REGION_RODATA_LOAD
> -       .rtemsroset : ALIGN_WITH_INPUT SUBALIGN(bsp_set_align) {
> +       .rtemsroset : ALIGN_WITH_INPUT {
>                 /* Special FreeBSD linker set sections */
>                 __start_set_sysctl_set = .;
>                 *(set_sysctl_*);
> @@ -299,7 +299,7 @@ SECTIONS {
>         .data1 : ALIGN_WITH_INPUT {
>                 *(.data1)
>         } > REGION_DATA AT > REGION_DATA_LOAD
> -       .rtemsrwset : ALIGN_WITH_INPUT SUBALIGN(bsp_set_align) {
> +       .rtemsrwset : ALIGN_WITH_INPUT {
>                 KEEP (*(SORT(.rtemsrwset.*)))
>                 bsp_section_data_end = .;
>         } > REGION_DATA AT > REGION_DATA_LOAD
> --
> 2.20.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list