[PATCH v3 2/4] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

Ryan Long thisisryanlong at gmail.com
Fri Mar 5 20:42:29 UTC 2021


CID 1063856: Unchecked return value from library in
rtems_shell_main_chmod().

Closes #4281
---
 cpukit/libmisc/shell/main_chmod.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c
index 0c39072..8b932fa 100644
--- a/cpukit/libmisc/shell/main_chmod.c
+++ b/cpukit/libmisc/shell/main_chmod.c
@@ -34,6 +34,7 @@ static int rtems_shell_main_chmod(
   int           n;
   mode_t        mode;
   unsigned long tmp;
+  int           sc;
 
   if (argc < 2) {
     fprintf(stderr,"%s: too few arguments\n", argv[0]);
@@ -52,8 +53,10 @@ static int rtems_shell_main_chmod(
   /*
    *  Now change the files modes
    */
-  for (n=2 ; n < argc ; n++)
-    chmod(argv[n++], mode);
+  for (n=2 ; n < argc ; n++) {
+    sc = chmod(argv[n++], mode);
+    _Assert_Unused_variable_unequal(sc, -1);
+  }
 
   return 0;
 }
-- 
1.8.3.1



More information about the devel mailing list