[PATCH 2/3] covoar: Improve findCoverageMap error message

Alex White alex.white at oarcorp.com
Tue Mar 16 13:53:33 UTC 2021


This patch no longer applies assuming that the latest revision of my earlier patch, "covoar: Handle periods in symbols from objdump",  is accepted.

-----Original Message-----
From: Alex White <alex.white at oarcorp.com> 
Sent: Friday, March 12, 2021 11:14 AM
To: devel at rtems.org
Cc: Alex White <alex.white at oarcorp.com>
Subject: [PATCH 2/3] covoar: Improve findCoverageMap error message

---
 tester/covoar/ExecutableInfo.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc index 5a730fd..30828a6 100644
--- a/tester/covoar/ExecutableInfo.cc
+++ b/tester/covoar/ExecutableInfo.cc
@@ -177,7 +177,9 @@ namespace Coverage {
 
     if (periodIndex == std::string::npos) {
       // Symbol name has no '.', can't do another lookup.
-      throw rld::error (symbolName, "ExecutableInfo::findCoverageMap");
+      std::ostringstream what;
+      what << "Could not find " << symbolName;
+      throw rld::error (what, "ExecutableInfo::findCoverageMap");
     }
 
     cmi = coverageMaps.find(
@@ -185,7 +187,9 @@ namespace Coverage {
     );
 
     if ( cmi == coverageMaps.end() ) {
-      throw rld::error (symbolName, "ExecutableInfo::findCoverageMap");
+      std::ostringstream what;
+      what << "Could not find " << symbolName;
+      throw rld::error (what, "ExecutableInfo::findCoverageMap");
     }
 
     return *(cmi->second);
--
2.27.0



More information about the devel mailing list