[PATCH v1 2/5] libcsupport: Implement utime() in terms of utimensat()

[Ryan Long]

-----Original Message-----
From: Sebastian Huber <sebastian.huber at embedded-brains.de> 
Sent: Monday, May 3, 2021 11:54 PM
To: Ryan Long <ryan.long at oarcorp.com>; devel at rtems.org
Subject: Re: [PATCH v1 2/5] libcsupport: Implement utime() in terms of utimensat()

On 03/05/2021 15:40, Ryan Long wrote:

> utime() now calls utimensat() to update file access and modification 
> timestamps.
Mention license change?
[Ryan Long] I'll add that for V2.
>
> Closes #4397
> ---
>   cpukit/libcsupport/src/utime.c | 74 +++++++++++++++++++++++-------------------
>   1 file changed, 41 insertions(+), 33 deletions(-)
>
> diff --git a/cpukit/libcsupport/src/utime.c 
> b/cpukit/libcsupport/src/utime.c index e2d8883..610ce35 100644
> --- a/cpukit/libcsupport/src/utime.c
> +++ b/cpukit/libcsupport/src/utime.c
SDPX license identifier?
> @@ -1,58 +1,66 @@
>   /**
>    *  @file
>    *
> - *  @brief Set File Access and Modification Times
>    *  @ingroup libcsupport
> + *
> + *  @brief Set file access and modification times in seconds.

Does the file set the file access and modification times in seconds? I used the following term in my recent @file rework:

  * @brief This source file contains the implementation of utime().
[Ryan Long] utime() is used with filesystems that only use seconds for their file timestamps. Utimes() is used with filesystems that support millisecond granularity and utimensat() is used with filesystems that support nanosecond granularity. I'll change that brief though.

>    */
>   
>   /*
> - *  COPYRIGHT (c) 1989-1999.
> + *  COPYRIGHT (c) 1989-2009, 2021.
>    *  On-Line Applications Research Corporation (OAR).

This copyright line doesn't match the new template. Could we please use the new template or update it to allow more formats. In the future we could use the copyright statement patterns in a script.
[Ryan Long] Since the template is 'Copyright (C) <FIRST YEAR>, <LAST YEAR> <COPYRIGHT HOLDER>', I should change it to 'Copyright (C) 1989, 2021 On-Line Applications Research Corporation (OAR)'?

>    *
> - *  The license and distribution terms for this file may be
> - *  found in the file LICENSE in this distribution or at
> - *http://www.rtems.org/license/LICENSE.
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.

--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/