[PATCH] waf: Add --rtems-version as a configure option

Sebastian Huber sebastian.huber at embedded-brains.de
Sun Nov 14 12:15:39 UTC 2021


On 14/11/2021 04:07, chrisj at rtems.org wrote:
> From: Chris Johns <chrisj at rtems.org>
> 
> - Provide the option `--rtems-version` to set the major version
>    number
> 
> - Add a method to handle setting action values
> 
> - Return the spec YAML file back to it's original values
>    as it does not allow a user to change the version.
> 
> Closes #4548

I would simply revert the optvermaj.yml patch with "git revert".

I don't like the special case approach which violates one design 
principle of the build system that the wcript should know the absolute 
minimum of the layout of the build specification.

My preferred solution would be that the build item defines that it can 
be modified by a command line option, for example:

./waf configure --rtems-set-value=__RTEMS_MAJOR__=7

In spec/build/cpukit/optvermaj.yml:

actions:
- get-string-option: '6'
- env-assign

With this approach you don't give the user the ability to change 
everything. However, what can be change is defined by the build 
specification and not the wscript.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list