[PATCH] waf: Add --rtems-version as a configure option

Chris Johns chrisj at rtems.org
Mon Nov 15 21:49:52 UTC 2021


On 15/11/21 7:09 pm, Sebastian Huber wrote:
> On 14/11/2021 23:42, Chris Johns wrote:
>>> With this approach you don't give the user the ability to change everything.
>>> However, what can be change is defined by the build specification and not the
>>> wscript.
>> I understand the reason however you would need to implement it to show how it is
>> done? Can we internally do:
>>
>>   set_value("__RTEMS_MAJOR__", ctx.options.rtems_version)
>>
>> ? I do not understand the how to make the change and then manage the sequence
>> via the actions.
> 
> Please have a look at for a proof of concept:
> 
> https://lists.rtems.org/pipermail/devel/2021-November/069889.html

Really nice and I like the idea of `get-string-command-line`. Having this in the
spec files is important if you want to know what can be changed. The prepare
step is a nice way to sequence the steps and the bit I was not sure about.

> We can also add --rtems-version=X and map it to __RTEMS_MAJOR=X in the wscipt.

Is adding this something specific? I would like to see the option directly
supported.

Thank you for the patch and the prompt response.

Chris


More information about the devel mailing list