[PATCH 6/7] score: Always validate ticks in _TOD_Validate()

Chris Johns chrisj at rtems.org
Sat Sep 4 04:10:15 UTC 2021


On 3/9/21 11:33 pm, Sebastian Huber wrote:
> diff --git a/bsps/arm/altera-cyclone-v/rtc/rtc.c b/bsps/arm/altera-cyclone-v/rtc/rtc.c
> index 779a093459..d1c12ee874 100644
> --- a/bsps/arm/altera-cyclone-v/rtc/rtc.c
> +++ b/bsps/arm/altera-cyclone-v/rtc/rtc.c
> @@ -353,7 +353,7 @@ static int altera_cyclone_v_ds1339_get_time(int minor, rtems_time_of_day* tod)
>      temp_tod.month  = ds1339_get_month(&time);
>      temp_tod.year   = ds1339_get_year(&time);
>  
> -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION);
> +    sc = _TOD_Validate(&temp_tod);

This has leaked out of the internal implementation interface. Should it?

I prefer this does not happen and BSPs use an API.

Chris


More information about the devel mailing list