[PATCH v4] improve the format of error reporting on i386

[Gedare Bloom]

Hi Zack,

I think you have also missed Joel's request to add an 8-character
width specifier.

On Thu, Sep 16, 2021 at 6:19 PM zack leung <zakthertemsdev at gmail.com> wrote:
>
> Thread id is now a Hex value. formatting improved for hex values
> Updates #4203
> ---
>  cpukit/score/cpu/i386/cpu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c
> index 77b7a7161c..0f17cf0148 100644
> --- a/cpukit/score/cpu/i386/cpu.c
> +++ b/cpukit/score/cpu/i386/cpu.c
> @@ -215,16 +215,16 @@ void _CPU_Exception_frame_print (const
> CPU_Exception_frame *ctx)
>  {
>    unsigned int faultAddr = 0;
>    printk("----------------------------------------------------------\n");
> -  printk("Exception %" PRIu32 " caught at PC %" PRIx32 " by thread %"
> PRId32 "\n",
> +  printk("Exception %" PRIu32 " caught at PC 0x%" PRIx32 " by thread 0x%"
> PRIx32 "\n",
>       ctx->idtIndex,
>       ctx->eip,
>       _Thread_Executing->Object.id);
>    printk("----------------------------------------------------------\n");
>    printk("Processor execution context at time of the fault was  :\n");
>    printk("----------------------------------------------------------\n");
> -  printk(" EAX = %" PRIx32 "    EBX = %" PRIx32 "    ECX = %" PRIx32 "
> EDX = %" PRIx32 "\n",
> +  printk(" EAX = 0x%" PRIx32 "    EBX = 0x%" PRIx32 "    ECX = 0x%" PRIx32
> "    EDX = 0x%" PRIx32 "\n",
>       ctx->eax, ctx->ebx, ctx->ecx, ctx->edx);
> -  printk(" ESI = %" PRIx32 "    EDI = %" PRIx32 "    EBP = %" PRIx32 "
> ESP = %" PRIx32 "\n",
> +  printk(" ESI = 0x%" PRIx32 "    EDI = 0x%" PRIx32 "    EBP = 0x%" PRIx32
> "    ESP = 0x%" PRIx32 "\n",
>       ctx->esi, ctx->edi, ctx->ebp, ctx->esp0);
>    printk("----------------------------------------------------------\n");
>    printk("Error code pushed by processor itself (if not 0) = %" PRIx32
> "\n",
> --
> 2.33.0
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel