[PATCH v1 2/5] testsuites/smpmulticast01: Enforce step ordering

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Sep 21 05:47:02 UTC 2021


On 20/09/2021 23:38, Kinsey Moore wrote:
> The order in which step checks for 1 and 2 are not rigidly defined and
> may actually occur in either order depending on how the threads execute.
> This waits for the job to complete to enforce the existing ordering.
> ---
>   testsuites/smptests/smpmulticast01/init.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/testsuites/smptests/smpmulticast01/init.c b/testsuites/smptests/smpmulticast01/init.c
> index 4163dd8370..ec4bab922d 100644
> --- a/testsuites/smptests/smpmulticast01/init.c
> +++ b/testsuites/smptests/smpmulticast01/init.c
> @@ -506,6 +506,7 @@ T_TEST_CASE(AddJobInJob)
>     _Per_CPU_Add_job(cpu_self, &add_job_in_job_jobs[0]);
>     T_step(0);
>     _SMP_Send_message(cpu_self, SMP_MESSAGE_PERFORM_JOBS);
> +  _Per_CPU_Wait_for_job(cpu_self, &add_job_in_job_jobs[0]);
>     T_step(2);
>     _SMP_Send_message(cpu_self, SMP_MESSAGE_PERFORM_JOBS);
>     _Thread_Dispatch_enable(cpu_self);

This patch is fine. It seems that there could be a delay before the 
interrupt issued by _SMP_Send_message() is actually serviced on this 
platform.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list