[PATCH] bsp/stm32h7: update FMC configuration for SRAM and SDRAM usage
Sebastian Huber
sebastian.huber at embedded-brains.de
Thu Apr 7 06:07:06 UTC 2022
On 06/04/2022 14:21, Karel Gardas wrote:
> let me explain more motivation behind this patch. I'm working on
> stm32h757i-eval bsp variant and while looking into FMC support while
> using STM32CubeIDE I've noticed that actual changes between
> system_stm32h7xx.c files generated for H743i-eval and H757i-eval are
> pretty minimal much less than between RTEMS's ext-mem-ctl and
> system_stm32h7xx.c for H757i-eval.
> So what this patch does is update H743i-eval values to the latest
> generated by IDE and by this minimize differences between H743i-eval and
> future H757i-eval variant.
>
> The problem with this patch is that I do not have 743i-eval2 board for
> testing here. So basically patch is provided in a best hope that it'll
> be working on your board.
>
> If you do not accept this, then the other way around this would be big
> #ifdef between 743 and 757 and this would be maintainer nightmare I
> would guess so I'm offering this way first for your review and
> consideration.
>
> Please let me know if you would like to have this situation handled
> differently or would like to have any changes to the patch.
I checked in the patch. Could you please keep the subject to the usual
line length in the future.
What is important is that the changes are in self-contained commits. If
it breaks a certain board configuration, then you can find it quickly
with a git bisect.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
More information about the devel
mailing list