AW: [PATCH 06/12] kern_tc.c: Replace FREEBSD event mechanism by adding pointers to function

Gabriel.Moyano at dlr.de Gabriel.Moyano at dlr.de
Thu Apr 7 09:57:54 UTC 2022


> On 07/04/2022 10:36, Gabriel Moyano wrote:
> > +#else /* __rtems__ */
> > +            if (pps->wait_event != NULL)
> > +                err = (*pps->wait_event)(pps, fapi->timeout);
> > +            else
> > +                err = EAGAIN;
> > +#endif /* __rtems__ */
> >   			if (err == EWOULDBLOCK) {
> >   				if (fapi->timeout.tv_sec == -1) {
> >   					continue;
> > @@ -2227,7 +2240,12 @@ pps_event(struct pps_state *pps, int event)
> >   #endif
> >
> >   	/* Wakeup anyone sleeping in pps_fetch().  */
> > +#ifndef __rtems__
> >   	wakeup(pps);
> > +#else /* __rtems__ */
> > +    if (pps->wakeup != NULL)
> > +        (*pps->wakeup)(pps);
> > +#endif /* __rtems__ */
> 
> I would not allow a NULL pointer here. The driver shall provide callbacks.

Do you mean to add an assert?


More information about the devel mailing list