[PATCH v1] bsps/amd64: remove -Werror from ABI flags

[Chris Johns]

Stephen,

The email address in the patch is not yours or not set on your system and the
commit message line length exceeds 80 characters. It has been pushed and cannot
be changed so it would be good if you could please check your set up to make
sure patches are suitable for the repo.

Thanks
Chris

On 23/8/2022 6:14 am, Stephen Clark wrote:
> From: Stephen Clark <sclark at localhost.localdomain>
> 
> The ABI flags for the amd64 BSP contain the -Werror=return-type flag. There is no reason for this to be there so it has been removed. The same option has also been removed amd64.cfg file.
> ---
>  bsps/x86_64/amd64/config/amd64.cfg   | 1 -
>  spec/build/bsps/x86_64/amd64/abi.yml | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/bsps/x86_64/amd64/config/amd64.cfg b/bsps/x86_64/amd64/config/amd64.cfg
> index ad861cb867..fe19a9ee55 100644
> --- a/bsps/x86_64/amd64/config/amd64.cfg
> +++ b/bsps/x86_64/amd64/config/amd64.cfg
> @@ -11,6 +11,5 @@ CPU_CFLAGS  = -mno-red-zone
>  # way we can avoid linker-time relocation errors spawning from values being
>  # larger than their optimized container sizes.
>  CPU_CFLAGS += -mcmodel=large
> -CPU_CFLAGS += -Werror=return-type
>  
>  LDFLAGS = -Wl,--gc-sections
> diff --git a/spec/build/bsps/x86_64/amd64/abi.yml b/spec/build/bsps/x86_64/amd64/abi.yml
> index ca5a815c24..3e8748d069 100644
> --- a/spec/build/bsps/x86_64/amd64/abi.yml
> +++ b/spec/build/bsps/x86_64/amd64/abi.yml
> @@ -9,7 +9,6 @@ copyrights:
>  default:
>  - -mno-red-zone
>  - -mcmodel=large
> -- -Werror=return-type
>  default-by-variant: []
>  description: |
>    ABI flags