[PATCH rtems-lwip] lwip.py: Address python formatting issues

Kinsey Moore kinsey.moore at oarcorp.com
Tue Aug 30 13:09:39 UTC 2022


On 8/29/2022 17:06, Chris Johns wrote:
> On 30/8/2022 4:30 am, Kinsey Moore wrote:
>> ---
>>   lwip.py | 106 ++++++++++++++++++++++++++++++++------------------------
>>   1 file changed, 61 insertions(+), 45 deletions(-)
>>
>> diff --git a/lwip.py b/lwip.py
>> index f8d8eb0..2e12957 100644
>> --- a/lwip.py
>> +++ b/lwip.py
>> @@ -29,43 +29,50 @@ from rtems_waf import rtems
>>   import json
>>   import os
>>   
>> +
>>   def removeprefix(data, prefix):
>>       if data.startswith(prefix):
>>           return data[len(prefix):]
>>       return data
>>   
>> +
>> +xilinx_lwip_prefix = 'embeddedsw/ThirdParty/sw_services/lwip211/'
>> +
>>   xilinx_drv_incl = ''
>> -xilinx_drv_incl += './embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/include '
>> -xilinx_drv_incl += './embeddedsw/lib/bsp/standalone/src/common '
>> -xilinx_drv_incl += './embeddedsw/XilinxProcessorIPLib/drivers/common/src/ '
>> -xilinx_drv_incl += './embeddedsw/XilinxProcessorIPLib/drivers/scugic/src '
>> -xilinx_drv_incl += './embeddedsw/XilinxProcessorIPLib/drivers/emacps/src '
>> -xilinx_drv_incl += './rtemslwip/xilinx '
>> +xilinx_drv_incl += xilinx_lwip_prefix + 'src/contrib/ports/xilinx/include '
>> +xilinx_drv_incl += 'embeddedsw/lib/bsp/standalone/src/common '
>> +xilinx_drv_incl += 'embeddedsw/XilinxProcessorIPLib/drivers/common/src/ '
>> +xilinx_drv_incl += 'embeddedsw/XilinxProcessorIPLib/drivers/scugic/src '
>> +xilinx_drv_incl += 'embeddedsw/XilinxProcessorIPLib/drivers/emacps/src '
>> +xilinx_drv_incl += 'rtemslwip/xilinx '
> Lists or strings? I prefer lists because weird paths can effect the waf
> conversion from strings to lists.
>
> This also goes for defines, fkags etc.

I'll go ahead and get this committed and then address the strings issue 
in another patch.


Thanks!


Kinsey



More information about the devel mailing list