[PATCH 00/12] Support gcov instrumentation

[Chris Johns]

On 1/7/2022 4:25 pm, Sebastian Huber wrote:
> On 01.07.22 08:22, Chris Johns wrote:
>>>> I am encouraged by some of the generated code I have reviewed. I like what it
>>>> does.
>>>>
>>>>>> I am a little lost with the difference between LIBRARY_OPTIMIZATION_FLAGS and
>>>>>> OPTIMIZATION_FLAGS? RTEMS is always a library so what is difference between
>>>>>> them? Are the OPTIMIZATION_FLAGS the "-O" ones and still something I can set
>>>>>> from an INI file?
>>>>> Currently the OPTIMIZATION_FLAGS are used for all code (code for libraries and
>>>>> code for tests).  With this change you can build the libraries with -O0 and
>>>>> the
>>>>> tests with -O2 for example.
>>>> Oh so if I understand this the LIBRARY_OPTIMIZATION_FLAGS are per library?
>>> Not per library, the LIBRARY_OPTIMIZATION_FLAGS are used for all libraries in
>>> bsps and cpukit.
>> Is LIBRARY_OPTIMIZATION_FLAGS then a good choice? Would more direct naming like
>> BSP_OPTIMIZATION_FLAGS and CPUKIT_OPTIMIZATION_FLAGS be better? If this was in
>> the patch I would have understood exactly what they do.
> 
> The BSP is just a library: librtemsbsp.a. I can split LIBRARY_OPTIMIZATION_FLAGS
> into BSP_OPTIMIZATION_FLAGS and CPUKIT_OPTIMIZATION_FLAGS if this helps.

I think it does.

Thanks
Chris