[PATCH] bsps/microblaze: Fix build option definition order

[Joel Sherrill]

I'm ok with this but since you said Sebastian committed something which
broke this, it would be good for him to ack as well.

Are there other BSPs which might have this issue?

On Thu, Jul 7, 2022 at 2:20 PM Alex White <alex.white at oarcorp.com> wrote:

> The build option definitions were rearranged such that the option
> definitions used in the linker script were not available. This caused
> linker errors when building.
> ---
>  spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml      | 2 --
>  spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml | 2 --
>  spec/build/bsps/microblaze/microblaze_fpga/grp.yml            | 2 ++
>  3 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml
> b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml
> index c31ca37e9b..9ec29f49f6 100644
> --- a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml
> +++ b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml
> @@ -11,8 +11,6 @@ family: microblaze_fpga
>  includes: []
>  install: []
>  links:
> -- role: build-dependency
> -  uid: linkcmds
>  - role: build-dependency
>    uid: tstkcu105_qemu
>  - role: build-dependency
> diff --git a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml
> b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml
> index 39a5ca35d1..9a1147297a 100644
> --- a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml
> +++ b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml
> @@ -11,8 +11,6 @@ family: microblaze_fpga
>  includes: []
>  install: []
>  links:
> -- role: build-dependency
> -  uid: linkcmds
>  - role: build-dependency
>    uid: tstkcu105_qemu
>  - role: build-dependency
> diff --git a/spec/build/bsps/microblaze/microblaze_fpga/grp.yml
> b/spec/build/bsps/microblaze/microblaze_fpga/grp.yml
> index 2473ab8fe8..5fa21e4fa3 100644
> --- a/spec/build/bsps/microblaze/microblaze_fpga/grp.yml
> +++ b/spec/build/bsps/microblaze/microblaze_fpga/grp.yml
> @@ -60,6 +60,8 @@ links:
>    uid: ../../objirq
>  - role: build-dependency
>    uid: ../../objmem
> +- role: build-dependency
> +  uid: linkcmds
>  - role: build-dependency
>    uid: ../../bspopts
>  type: build
> --
> 2.32.0
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20220707/313d8067/attachment.htm>