Fwd: New Defects reported by Coverity Scan for RTEMS

[Joel Sherrill]

---------- Forwarded message ---------
From: <scan-admin at coverity.com>
Date: Wed, Jun 22, 2022, 1:54 AM
Subject: New Defects reported by Coverity Scan for RTEMS
To: <build at rtems.org>


Hi,

Please find the latest report on new defect(s) introduced to RTEMS found
with Coverity Scan.

2 new defect(s) introduced to RTEMS found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1506523:  Error handling issues  (CHECKED_RETURN)
/cpukit/libfs/src/ftpfs/tftpDriver.c: 727 in process_data_packet()


________________________________________________________________________________________________________
*** CID 1506523:  Error handling issues  (CHECKED_RETURN)
/cpukit/libfs/src/ftpfs/tftpDriver.c: 727 in process_data_packet()
721         if (tp->at_eof) {
722             plen = prepare_ack_packet_for_sending (tp, true, &send_buf,
NULL, NULL);
723
724             /*
725              * Send it. Errors during send will not matter for this
last ACK.
726              */
>>>     CID 1506523:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "sendto(tp->socket, send_buf, plen, 0, (struct sockaddr
*)&tp->farAddress, 16U)" without checking return value. This library
function may fail and return an error code.
727             sendto (
728                 tp->socket,
729                 send_buf,
730                 plen,
731                 0,
732                 (struct sockaddr *) &tp->farAddress,

** CID 1506522:  Error handling issues  (CHECKED_RETURN)
/cpukit/libfs/src/ftpfs/tftpDriver.c: 529 in send_error()


________________________________________________________________________________________________________
*** CID 1506522:  Error handling issues  (CHECKED_RETURN)
/cpukit/libfs/src/ftpfs/tftpDriver.c: 529 in send_error()
523         }
524         len += sizeof (msg.opcode) + sizeof (msg.errorCode) + 1;
525
526         /*
527          * Send it
528          */
>>>     CID 1506522:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "sendto(tp->socket, (char *)&msg, len, 0, (struct sockaddr
*)to, 16U)" without checking return value. This library function may fail
and return an error code.
529         sendto (tp->socket, (char *)&msg, len, 0, (struct sockaddr
*)to, sizeof *to);
530     }
531
532     /*
533      * Send a message to make the other end shut up
534      */


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypUUzi-2FdSNmuyRB7BEFT8xQ4-2B8hpujh0hTgQljRGId4Dg-3D-3DYDHO_EU3W9teASMK00lBXX9WT4lsogDrkCcNZLvg-2FVxwAXMrH8dAzPlWwiDYV1U-2F8xymjxfhXw64FmQzC9v0sejwWoxbemyTlKty07VAeUEneYgIIfMdwjCEXcgn0Re6oeOSfglcSXS8UfePUftOOg0aPvHZGZ-2FivjJ4qNrmfe53lCcuzTJT3zjQOLsqCN9TcK7sxd1vR1mMgE-2BjmivxhPcovrA-3D-3D

_______________________________________________
build mailing list
build at rtems.org
http://lists.rtems.org/mailman/listinfo/build
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20220622/b92dd52d/attachment-0001.htm>