Warnings when building sparc/leon3

Joel Sherrill joel at rtems.org
Tue Mar 8 15:51:56 UTC 2022


On Tue, Mar 8, 2022 at 9:18 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

>
>
> On 08/03/2022 15:52, Joel Sherrill wrote:
> >     We could change rtems_configuration_get_user_multiprocessing_table()
> to
> >     return NULL if CONFIGURE_MP_APPLICATION is not defined.
> >
> >
> > That's how it is now.
> >
> > #if defined(RTEMS_MULTIPROCESSING)
> >    #define rtems_configuration_get_user_multiprocessing_table() \
> >      ( &_MPCI_Configuration )
>
> This could be change to something like:
>
> ( _MPCI_Application ? &_MPCI_Configuration : NULL )
>
>
This would reflect the original semantics and be better.

Ryan's patch would not be needed in this case.


> With
>
> #ifdef CONFIGURE_MP_APPLICATION
>
> const bool _MPCI_Application = true;
>
> #else
>
> const bool _MPCI_Application = false;
>
> #endif
>
> > #else
> >    #define rtems_configuration_get_user_multiprocessing_table() NULL
> > #endif
> >
> > I think all the use cases Ryan and I saw were protected by ifdef
> > RTEMS_MULTIPROCESSING. Perhaps this just should not be defined
> > if it isn't configured.
>
> The API directives are always provided.
>
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber at embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>


More information about the devel mailing list