[PATCH] spec/build/bsps: Fix blank variables

[Joel Sherrill]

On Wed, Mar 9, 2022 at 4:24 PM Heinz Junkes <junkes at fhi-berlin.mpg.de>
wrote:

> Thanks for that. I've been struggling with this for a while ;-)
>
> But there is this comment in the file:
> “
> #
> # BSP specific settings. To be included in application Makefiles
> #
> # This support will be removed from RTEMS. Please consider other
> # ways to build applications.
> #
> “
> I thought this was no longer maintained and the "correct" way is now
> pkg-config?
> Or am I wrong here?
>

pkg-config is better. I think Chris has mentioned issues with it but I
don't know what they might be.

Removing these is an ongoing debate. The rtems-examples are the only user
left within the RTEMS Project. And you can build them with waf.

AFAIK they generally still work OK but you don't inherit the optimization
or warning CFLAGS like you once did.

Unless there is a giant upswell of support, I'm prone to acquiesce and let
them be removed after 6.

But apparently you are using it. What's the scope of that?

--joel


>
> Danke Heinz
>
>
>
> > On 9. Mar 2022, at 22:02, Ryan Long <ryan.long at oarcorp.com> wrote:
> >
> > Several variables in the installed Makefile.inc, target.cfg, and bsp.cfg
> > had values that were not being initialized to yes or no as they should
> > be. Reordering the files and adding an initialization using yesno() to
> > RTEMS_HAS_NETWORKING fixed this issue.
> > ---
> > spec/build/bsps/grpmake.yml | 8 ++++----
> > spec/build/bsps/optmake.yml | 1 +
> > 2 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/spec/build/bsps/grpmake.yml b/spec/build/bsps/grpmake.yml
> > index 0998efc..f4a21f2 100644
> > --- a/spec/build/bsps/grpmake.yml
> > +++ b/spec/build/bsps/grpmake.yml
> > @@ -30,15 +30,15 @@ install:
> > ldflags: []
> > links:
> > - role: build-dependency
> > -  uid: makebsp
> > -- role: build-dependency
> >   uid: makecustom
> > - role: build-dependency
> > +  uid: optmake
> > +- role: build-dependency
> > +  uid: makebsp
> > +- role: build-dependency
> >   uid: makeinc
> > - role: build-dependency
> >   uid: maketarget
> > -- role: build-dependency
> > -  uid: optmake
> > type: build
> > use-after: []
> > use-before: []
> > diff --git a/spec/build/bsps/optmake.yml b/spec/build/bsps/optmake.yml
> > index 28e9660..bea2c90 100644
> > --- a/spec/build/bsps/optmake.yml
> > +++ b/spec/build/bsps/optmake.yml
> > @@ -7,6 +7,7 @@ actions:
> >         return "no"
> >     conf.env["RTEMS_HAS_MULTIPROCESSING"] = yesno(conf,
> "RTEMS_MULTIPROCESSING")
> >     conf.env["RTEMS_HAS_POSIX_API"] = yesno(conf, "RTEMS_POSIX_API")
> > +    conf.env["RTEMS_HAS_NETWORKING"] = yesno(conf, "RTEMS_NETWORKING")
> > build-type: option
> > copyrights:
> > - Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de
> )
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel