[PATCH] spec/build/bsps: Fix blank variables

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Mar 10 06:52:34 UTC 2022


On 09/03/2022 22:02, Ryan Long wrote:
> Several variables in the installed Makefile.inc, target.cfg, and bsp.cfg
> had values that were not being initialized to yes or no as they should
> be. 

What are "several variables"?

> Reordering the files and adding an initialization using yesno() to
> RTEMS_HAS_NETWORKING fixed this issue.
> ---
>   spec/build/bsps/grpmake.yml | 8 ++++----
>   spec/build/bsps/optmake.yml | 1 +
>   2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/spec/build/bsps/grpmake.yml b/spec/build/bsps/grpmake.yml
> index 0998efc..f4a21f2 100644
> --- a/spec/build/bsps/grpmake.yml
> +++ b/spec/build/bsps/grpmake.yml
> @@ -30,15 +30,15 @@ install:
>   ldflags: []
>   links:
>   - role: build-dependency
> -  uid: makebsp
> -- role: build-dependency
>     uid: makecustom
>   - role: build-dependency
> +  uid: optmake
> +- role: build-dependency
> +  uid: makebsp
> +- role: build-dependency
>     uid: makeinc
>   - role: build-dependency
>     uid: maketarget
> -- role: build-dependency
> -  uid: optmake
>   type: build
>   use-after: []
>   use-before: []
> diff --git a/spec/build/bsps/optmake.yml b/spec/build/bsps/optmake.yml
> index 28e9660..bea2c90 100644
> --- a/spec/build/bsps/optmake.yml
> +++ b/spec/build/bsps/optmake.yml
> @@ -7,6 +7,7 @@ actions:
>           return "no"
>       conf.env["RTEMS_HAS_MULTIPROCESSING"] = yesno(conf, "RTEMS_MULTIPROCESSING")
>       conf.env["RTEMS_HAS_POSIX_API"] = yesno(conf, "RTEMS_POSIX_API")
> +    conf.env["RTEMS_HAS_NETWORKING"] = yesno(conf, "RTEMS_NETWORKING")
>   build-type: option
>   copyrights:
>   - Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)

The RTEMS_NETWORKING option no longer exists, so this should be a hared 
coded "no".

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list