AW: [PATCH v2 11/12] timepps.h: Move hardpps to the _ namespace

[Sebastian Huber]

On 04/05/2022 08:09, Gabriel.Moyano at dlr.de wrote:
>> On 29/04/2022 09:20, Gabriel Moyano wrote:
>>> ---
>>>    cpukit/include/sys/timepps.h | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/cpukit/include/sys/timepps.h
>>> b/cpukit/include/sys/timepps.h index b13ac6bf26..25370f3f4b 100644
>>> --- a/cpukit/include/sys/timepps.h
>>> +++ b/cpukit/include/sys/timepps.h
>>> @@ -28,6 +28,7 @@
>>>    #include <rtems/score/atomic.h>
>>>    #include <rtems/rtems/types.h>
>>>    #define PPS_SYNC
>>> +#define hardpps _PPS_Discipline_cpu_clock
>>>    #endif /* __rtems__ */
>>>
>>>    #define PPS_API_VERS_1	1
>> This function needs Doxygen documentation somewhere. What is the "cpu_clock"? I would place it into the _Timecounter
>> namespace.
>>
> I was wondering if it makes sense to place it into _Timecounter.
> There is a very good description where hardpps() is defined, would you like to copy it?
> Just for clarification, the name "cpu_clock" comes from that documentation.

This comment contains also some historic stuff which doesn't apply to 
RTEMS. It would be good to give a short documentation what this function 
does and how it is used in the RTEMS context. The brief description 
should be probably be something like "Updates the timecounter frequency 
adjustment used by _Timecounter_NTP_update_second().".

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/