[PATCH 1/7] bsps/stm32h7: add board C files for stm32h757i-eval BSP

[Sebastian Huber]

On 19/05/2022 09:18, Karel Gardas wrote:
> On 5/19/22 09:06, Sebastian Huber wrote:
>> On 19/05/2022 09:03, Karel Gardas wrote:
>>> On 5/19/22 08:55, Sebastian Huber wrote:
>>>> On 16/05/2022 14:12, Karel Gardas wrote:
>>>>> + 
>>>>> ****************************************************************************** 
>>>>>
>>>>> +  * @attention
>>>>> +  *
>>>>> +  * Copyright (c) 2019 STMicroelectronics.
>>>>> +  * All rights reserved.
>>>>> +  *
>>>>> +  * This software is licensed under terms that can be found in the 
>>>>> LICENSE file
>>>>> +  * in the root directory of this software component.
>>>>> +  * If no LICENSE file comes with this software, it is provided 
>>>>> AS-IS.
>>>>> +  *
>>>>> + 
>>>>> ****************************************************************************** 
>>>>>
>>>>
>>>> A license text like this is a blocking issue from my point of view.
>>>
>>> We already have this in tree:
>>>
>>> bsps/arm/stm32h7/boards/stm/stm32h7b3i-dk/system_stm32h7xx.c
>>>
>>>
>>> ****************************************************************************** 
>>>
>>>    * @attention
>>>    *
>>>    * Copyright (c) 2018 STMicroelectronics.
>>>    * All rights reserved.
>>>    *
>>>    * This software is licensed under terms that can be found in the 
>>> LICENSE file
>>>    * in the root directory of this software component.
>>>    * If no LICENSE file comes with this software, it is provided AS-IS.
>>>    *
>>>
>>> ****************************************************************************** 
>>>
>>>
>>>
>>> and those files are simply generated by the STM32CubeIDE. "root 
>>> directory" is very confusing term here as the file is copied around 
>>> from IIRC STM32CubeH7 into project workspace directory when the 
>>> project is created...
>>>
>>> Anyway, STM32CubeH7 project provide a table listing licenses and the 
>>> file is part of BSP set and this is BSD-3-Clause.
>>>
>>> https://github.com/STMicroelectronics/STM32CubeH7/blob/master/LICENSE.md
>>
>> I think the text should be replaced by the BSD-3-Clause text from STM 
>> and an SPDX License Identifier on top of the file..
> 
> "replaced" is a bit stronger coffee than I'm able to accept here as a 
> patch provider.
> Anyway, let's do that on the file we already do have in a tree -- I'll 
> send you patch for review so let's discuss it then...

You can provide the file as is and in a second patch replace the text.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/