Review Request for DCAN patches

Prashanth S fishesprashanth at gmail.com
Wed Oct 26 19:01:53 UTC 2022


Hi Christian,

I squashed the commits and pushed to the same branch.
https://gitlab.com/slpp95prashanth/gsoc-2022/-/tree/can-dev-squashed1

Regards
Prashanth S


On Wed, 26 Oct, 2022, 10:56 pm , <oss at c-mauderer.de> wrote:

> Hello Prashanth,
>
> from my point of view the patches look good and I think you processed
> Gedares feedback too. So if no one objects I'll pus the patches on the
> weekend.
>
> Last version is this one:
>
>
> https://gitlab.com/slpp95prashanth/gsoc-2022/-/commits/30199c2af1c65f05f820a/
>
> Like discussed in Discord, it would be good to squash the canqueueimpl.h
> into the CAN support. Either you can do that or I'll do it right before
> pushing.
>
> Best regards
>
> Christian
>
> Am 16.10.22 um 19:12 schrieb Prashanth S:
> > Hi All,
> >
> > This is a review request for the DCAN patch, I have updated the files
> > based on review comments.
> > Attaching the patch as a zip file.
> >
> > Regards
> > Prashanth S
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20221027/461f2ce2/attachment.htm>


More information about the devel mailing list