[rtems-tools PATCH] rtemstoolkit: Fix shell execution

[Chris Johns]

On 30/8/2023 5:44 am, Joel Sherrill wrote:
> A bit more feedback. I got this failure on CentOS 7 building sparc-rtems6 tools.
> 
> + cd rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8
> + ./waf distclean configure --prefix=/home/joel/rtems-work/tools/6
> 'distclean' finished successfully (0.001s)
> Setting top to                           :
> /home/joel/rtems-work/rtems-source-builder/rtems/build/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8
> Setting out to                           :
> /home/joel/rtems-work/rtems-source-builder/rtems/build/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8/build
> invalid version file: 'module' object has no attribute 'join'
> (complete log in
> /home/joel/rtems-work/rtems-source-builder/rtems/build/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8/build/config.log)
> shell cmd failed: /bin/sh -ex
>  /home/joel/rtems-work/rtems-source-builder/rtems/build/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1/do-build
> error: building rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1
> 
> I tried the same target on Rocky 9 and did not get this error.
> 
> I loaded the software collection for Python 3.6 on CentOS 7 and got this:
> 
> + ./waf distclean configure --prefix=/home/joel/rtems-work/tools/6
> 'distclean' finished successfully (0.001s)
> Setting top to                           :
> /home/joel/rtems-work/rtems-source-builder/rtems/build/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8
> Setting out to                           :
> /home/joel/rtems-work/rtems-source-builder/rtems/build/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8-1/rtems-tools-3ea0c249346fda427bf0d3c169aa3e7c2a521df8/build
> invalid version file: module 'shlex' has no attribute 'join'
> 
> Not sure what the common factor on all this is.

The `.join()` is documented with [1]:

  New in version 3.8.

I did not notice this.

Chris

[1] https://docs.python.org/3/library/shlex.html#shlex.join