[PATCH] spec/bsps: Deduplicate objxilinxsupport
sebastian.huber at embedded-brains.de
Thu Feb 9 09:38:36 UTC 2023
On 09.02.23 01:44, Chris Johns wrote:
> On 7/2/2023 5:55 pm, Sebastian Huber wrote:
>> On 06.02.23 23:09, Gedare Bloom wrote:
>>> ok. I'm not sure, maybe we need a note about this in
>> A hint in the documentation would be helpful. Even more helpful would be a
>> consistency check before patch sets are pulled in. For example, it is a bug if
>> you have a diamond in the build dependency graph and the nodes with an indegree
>> greater than one install files. If the nodes with an indegree greater than one
>> build source files with identical build options, then this is also a bug.
>> However, a valid special case could be a node which is built with different
>> build flags, for example:
>> lib -> grp_a (-DFLAG_A) -> objxyz
>> \---> grp_b (-DFLAG_B) -> objxyz
> I would expect that case would map to separate build objects?
For object files I think waf is able to support this. For installed
files it doesn't work.
> How do you suggest someone proceed to add a check?
> Would that check happen when the spec files are parsed? That is, we assume the
> pickled output loaded on each build is OK?
You don't have to check this during a build. These issues can be
detected by analyzing the build specification items. The support for
this is in rtems-central. So my proposal would be that we check this in
pull requests (which we don't have at the moment).
> Do we have any unittests for the build system? Adding a check would mean we need
> a test case to generate the problem?
It is possible to write unit tests for the build system and I did some
experiments with this while writing it. However, the unit tests are
quite incomplete, out dated, and not integrated.
embedded brains GmbH
Herr Sebastian HUBER
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
More information about the devel